Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use clang-format 15 after v7.4 #3170

Conversation

purelind
Copy link
Collaborator

Copy link

ti-chi-bot bot commented Oct 10, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, the key change here is the addition of a new stage named "clang-foramt-15" that installs clang-format-15.

Potential problems that could arise from this change include:

  1. The new stage might not be necessary, and it could increase the build time unnecessarily.
  2. The script to install clang-format-15 could fail for a variety of reasons (e.g., incorrect permissions, missing dependencies, etc.), which would cause the build to fail.

To address these potential problems, here are some suggestions:

  1. Double-check whether the new stage is necessary. If it is, consider adding some conditional logic to skip the stage if clang-format-15 is already installed.
  2. Add some error handling to the script to install clang-format-15. For example, you could use set -e to ensure that the script exits immediately if any command fails. You could also add some checks to ensure that the installation was successful (e.g., by running clang-format-15 --version and checking the output).

Overall, it seems like a relatively minor change that shouldn't cause too many issues, as long as the script to install clang-format-15 is robust.

Copy link

ti-chi-bot bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@purelind purelind changed the title fix: user clang-format 15 after v7.4 fix: use clang-format 15 after v7.4 Oct 10, 2024
@ti-chi-bot ti-chi-bot bot merged commit c1078a3 into PingCAP-QE:main Oct 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant