Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tiflash): use clang-format in image #3201

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Nov 4, 2024

Remove clang-format-12, since we do not maintain the llvm@12 image.

For v6.1 ~ v7.1, using clang-format-13
For v7.5 ~ v8.1, using clang-format-15

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Copy link

ti-chi-bot bot commented Nov 4, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the changes are related to using different versions of clang-format in the Tiflash image for different versions of v6.x, v7.x, and v8.x. The changes are removing the use of clang-format-12 and adding the use of clang-format-13 for v6.1 to v7.1, and clang-format-15 for v7.5 to v8.1.

There are no apparent problems with the changes. However, there are several typos in the code comments. For example, "foramt" should be "format", and "clang-foramt-12" should be "clang-format-12". These should be fixed to maintain code readability.

In addition, it might be helpful to include some information in the pull request description about why the image is being updated with different versions of clang-format for different versions of Tiflash. This could help other developers understand the reasoning behind the changes.

Overall, the changes themselves look fine and should be merged after fixing the typos and potentially adding more context in the description.

@ti-chi-bot ti-chi-bot bot added the size/S label Nov 4, 2024
@Lloyd-Pottiger
Copy link
Contributor Author

/cc @JaySon-Huang

Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Co-authored-by: JaySon <tshent@qq.com>
Copy link

ti-chi-bot bot commented Nov 4, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and description, it seems that the changes made in this PR are related to using different versions of clang-format in different versions of tiflash. The changes made in the pull request have removed clang-format-12 and updated the usage of clang-format in different versions of tiflash to use clang-format-13 for versions v6.1 to v7.1 and clang-format-15 for versions v7.5 to v8.1.

There don't seem to be any potential problems with these changes as they only update the usage of clang-format. However, there is a typo in the PR description where clang-foramt is misspelled instead of clang-format.

As for fixing suggestions, the typo in the PR description should be corrected. Additionally, it might be a good idea to add a brief explanation for why clang-format-12 was removed and why the updated versions of clang-format were chosen for different versions of tiflash. This would make it easier for future contributors to understand the reasoning behind the changes.

Copy link
Collaborator

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

ti-chi-bot bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 5, 2024
Copy link

ti-chi-bot bot commented Nov 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-05 02:32:57.905847422 +0000 UTC m=+921890.745002963: ☑️ agreed by purelind.

@ti-chi-bot ti-chi-bot bot added the approved label Nov 5, 2024
@ti-chi-bot ti-chi-bot bot merged commit e9658b4 into PingCAP-QE:main Nov 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants