-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tiflash): use clang-format in image #3201
chore(tiflash): use clang-format in image #3201
Conversation
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Based on the pull request title and description, it seems that the changes are related to using different versions of There are no apparent problems with the changes. However, there are several typos in the code comments. For example, "foramt" should be "format", and "clang-foramt-12" should be "clang-format-12". These should be fixed to maintain code readability. In addition, it might be helpful to include some information in the pull request description about why the image is being updated with different versions of Overall, the changes themselves look fine and should be merged after fixing the typos and potentially adding more context in the description. |
/cc @JaySon-Huang |
pipelines/pingcap/tiflash/release-7.5/pull_integration_test.groovy
Outdated
Show resolved
Hide resolved
pipelines/pingcap/tiflash/release-8.1/pull_integration_test.groovy
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Co-authored-by: JaySon <tshent@qq.com>
Based on the PR title and description, it seems that the changes made in this PR are related to using different versions of There don't seem to be any potential problems with these changes as they only update the usage of As for fixing suggestions, the typo in the PR description should be corrected. Additionally, it might be a good idea to add a brief explanation for why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: purelind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Remove clang-format-12, since we do not maintain the llvm@12 image.
For v6.1 ~ v7.1, using clang-format-13
For v7.5 ~ v8.1, using clang-format-15