Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Continuous Integration and increase test coverage #12

Open
satwikkansal opened this issue Jun 10, 2017 · 3 comments
Open

Add Continuous Integration and increase test coverage #12

satwikkansal opened this issue Jun 10, 2017 · 3 comments

Comments

@satwikkansal
Copy link

Hey, we've been using pyjsparser in our project coala-quickstart to parse JS files and extract information.

It would be great if we can have continuous integration for common platforms (ubuntu, windows, and osx) in the official repository of "pyjsparser".

Also, I tested the library for coverage and came to know it's around 30%. Maybe we can write more tests to improve the coverage of tests 😅

Let me know what do you think of these ideas. If ideas seem worth executing, I'll also be able to help in the above tasks 😄

@PiotrDabkowski
Copy link
Owner

PiotrDabkowski commented Jun 10, 2017

There is no need to write new tests, we can use the same tests as esprima - you can find them here. It should not be hard to integrate them, the syntax tree returned by pyesprima is almost identical to the one returned by esptima.js. Note that pyesprima is based on the older version of esprima (2.2.0) so we would have to use the older version of their tests as well.

I am currently working on my thesis and ML projects so I will not be able to do that right now. I can assist in the process though if you want to give it a try :)

@satwikkansal
Copy link
Author

Nice, I'm working on an information extraction project right now under coala for GSoC 17. I'll add the above mentioned tasks as stretch goals in my timeline and try them once I'm done with completing existing tasks that I've initially proposed for GSoC. Hope you're fine with this :)

@PiotrDabkowski
Copy link
Owner

Cool, good luck with the GSOC!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants