Skip to content

Commit

Permalink
fix plot_3d trying to connect end surfaces for zeta not 2pi cases
Browse files Browse the repository at this point in the history
  • Loading branch information
YigitElma committed Oct 20, 2023
1 parent b0794c9 commit 4d200ce
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion desc/plotting.py
Original file line number Diff line number Diff line change
Expand Up @@ -854,7 +854,10 @@ def plot_3d(

if grid.num_rho == 1:
n1, n2 = grid.num_theta, grid.num_zeta
p1, p2 = True, True
if not grid.nodes[-1][2] == 2 * np.pi:
p1, p2 = True, False

Check warning on line 858 in desc/plotting.py

View check run for this annotation

Codecov / codecov/patch

desc/plotting.py#L857-L858

Added lines #L857 - L858 were not covered by tests
else:
p1, p2 = True, True

Check warning on line 860 in desc/plotting.py

View check run for this annotation

Codecov / codecov/patch

desc/plotting.py#L860

Added line #L860 was not covered by tests
elif grid.num_theta == 1:
n1, n2 = grid.num_rho, grid.num_zeta
p1, p2 = False, True
Expand Down

0 comments on commit 4d200ce

Please sign in to comment.