You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some class attributes are not always the intended data type. For example, Equilibrium.NFP is supposed to be an int but in the past it was sometimes a float. More recently, I discovered that Equilibrium.sym was of type numpy.bool_ instead of the python bool, which is treated differently by the pytree utility functions we use in the coil objectives. I recommend we cast to the intended data type in class getter methods to ensure the returned type is always correct.
The text was updated successfully, but these errors were encountered:
Some class attributes are not always the intended data type. For example,
Equilibrium.NFP
is supposed to be anint
but in the past it was sometimes afloat
. More recently, I discovered thatEquilibrium.sym
was of typenumpy.bool_
instead of the pythonbool
, which is treated differently by the pytree utility functions we use in the coil objectives. I recommend we cast to the intended data type in class getter methods to ensure the returned type is always correct.The text was updated successfully, but these errors were encountered: