Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive quadrature option #1428

Open
unalmis opened this issue Dec 4, 2024 · 0 comments
Open

Adaptive quadrature option #1428

unalmis opened this issue Dec 4, 2024 · 0 comments
Labels
easy Short and simple to code or review P1 Lowest Priority, will get to eventually

Comments

@unalmis
Copy link
Collaborator

unalmis commented Dec 4, 2024

  • As discussed in some old pull requests, it could be useful to have an option to use adaptive quadrature for the bounce integrals. Since the fixed quadrature is limited by Patch for differentiable code with dynamic shapes #1303, the performance hit of an adaptive may not be that bad, since one could just check before applying the quadrature if the integrals has the same endpoints, and early exit before interpolating.

  • This should be a few line changes in the bounce.integrate method to using the adaptive quadrature from quadax.quadgk. In my testing for this months ago, I determined the most efficient option was the sin change of variables with Gauss-Kronrod.

@unalmis unalmis added good first issue Good for newcomers waiting for other PRs P1 Lowest Priority, will get to eventually easy Short and simple to code or review P2 Medium Priority, not urgent but should be on the near-term agend and removed waiting for other PRs good first issue Good for newcomers easy Short and simple to code or review P1 Lowest Priority, will get to eventually P2 Medium Priority, not urgent but should be on the near-term agend labels Dec 4, 2024
@unalmis unalmis added good first issue Good for newcomers P1 Lowest Priority, will get to eventually and removed P1 Lowest Priority, will get to eventually easy Short and simple to code or review good first issue Good for newcomers labels Dec 5, 2024
@YigitElma YigitElma changed the title Adaptive quadratue option Adaptive quadrature option Dec 6, 2024
@unalmis unalmis added the easy Short and simple to code or review label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Short and simple to code or review P1 Lowest Priority, will get to eventually
Projects
None yet
Development

No branches or pull requests

1 participant