Add aliases for data_index #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
kianorr
changed the title
|
Could be nice to also do this for the covariant basis vectors. Currently things like data["e_zeta_rtt"] = data["e_rho_ttz"]
return datawould make the code more maintainable. |
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | -1.68 +/- 1.01 | -3.24e-04 +/- 1.95e-04 | 1.90e-02 +/- 1.4e-04 | 1.93e-02 +/- 1.4e-04 |
test_build_transform_fft_midres | -0.77 +/- 0.85 | -8.65e-04 +/- 9.54e-04 | 1.11e-01 +/- 3.1e-04 | 1.12e-01 +/- 9.0e-04 |
test_build_transform_fft_highres | -0.40 +/- 0.70 | -2.07e-03 +/- 3.59e-03 | 5.13e-01 +/- 2.6e-03 | 5.15e-01 +/- 2.5e-03 |
test_equilibrium_init_lowres | -1.92 +/- 2.40 | -8.50e-03 +/- 1.06e-02 | 4.35e-01 +/- 5.2e-03 | 4.44e-01 +/- 9.3e-03 |
test_equilibrium_init_medres | -1.35 +/- 1.76 | -7.65e-03 +/- 9.95e-03 | 5.58e-01 +/- 6.1e-03 | 5.66e-01 +/- 7.8e-03 |
test_equilibrium_init_highres | -0.65 +/- 0.96 | -6.48e-03 +/- 9.53e-03 | 9.90e-01 +/- 7.3e-03 | 9.97e-01 +/- 6.1e-03 |
test_objective_compile_dshape_current | +0.10 +/- 7.65 | +5.09e-03 +/- 4.04e-01 | 5.29e+00 +/- 3.0e-01 | 5.28e+00 +/- 2.8e-01 |
test_objective_compile_atf | +0.07 +/- 5.25 | +1.03e-02 +/- 7.96e-01 | 1.52e+01 +/- 6.3e-01 | 1.52e+01 +/- 4.8e-01 |
test_objective_compute_dshape_current | -1.18 +/- 1.87 | -3.97e-05 +/- 6.29e-05 | 3.33e-03 +/- 3.0e-05 | 3.36e-03 +/- 5.5e-05 |
test_objective_compute_atf | -2.70 +/- 1.72 | -3.06e-04 +/- 1.95e-04 | 1.10e-02 +/- 1.4e-04 | 1.13e-02 +/- 1.3e-04 |
test_objective_jac_dshape_current | +2.12 +/- 8.53 | +2.67e-03 +/- 1.08e-02 | 1.29e-01 +/- 6.9e-03 | 1.26e-01 +/- 8.3e-03 |
test_objective_jac_atf | +1.52 +/- 1.81 | +9.71e-02 +/- 1.16e-01 | 6.49e+00 +/- 7.7e-02 | 6.39e+00 +/- 8.6e-02 |
test_perturb_1 | -1.99 +/- 13.85 | -1.73e-01 +/- 1.20e+00 | 8.49e+00 +/- 8.2e-01 | 8.66e+00 +/- 8.8e-01 |
test_perturb_2 | -0.94 +/- 5.74 | -1.55e-01 +/- 9.41e-01 | 1.62e+01 +/- 4.9e-01 | 1.64e+01 +/- 8.1e-01 | |
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | +0.90 +/- 2.73 | +1.72e-04 +/- 5.24e-04 | 1.93e-02 +/- 3.3e-04 | 1.92e-02 +/- 4.1e-04 |
test_build_transform_fft_midres | +0.18 +/- 0.76 | +1.98e-04 +/- 8.55e-04 | 1.13e-01 +/- 6.1e-04 | 1.13e-01 +/- 6.0e-04 |
test_build_transform_fft_highres | +0.20 +/- 0.96 | +1.05e-03 +/- 4.93e-03 | 5.16e-01 +/- 2.1e-03 | 5.15e-01 +/- 4.4e-03 |
test_equilibrium_init_lowres | -0.90 +/- 1.81 | -7.79e-03 +/- 1.57e-02 | 8.55e-01 +/- 1.1e-02 | 8.63e-01 +/- 1.1e-02 |
test_equilibrium_init_medres | +0.13 +/- 1.31 | +1.70e-03 +/- 1.66e-02 | 1.28e+00 +/- 1.0e-02 | 1.27e+00 +/- 1.3e-02 |
test_equilibrium_init_highres | -0.56 +/- 0.59 | -1.71e-02 +/- 1.79e-02 | 3.02e+00 +/- 1.2e-02 | 3.04e+00 +/- 1.3e-02 |
test_objective_compile_dshape_current | -2.05 +/- 7.35 | -1.12e-01 +/- 4.03e-01 | 5.37e+00 +/- 2.9e-01 | 5.49e+00 +/- 2.8e-01 |
test_objective_compile_atf | +2.44 +/- 5.31 | +4.24e-01 +/- 9.24e-01 | 1.78e+01 +/- 6.7e-01 | 1.74e+01 +/- 6.3e-01 |
test_objective_compute_dshape_current | -3.54 +/- 6.64 | -1.22e-04 +/- 2.29e-04 | 3.32e-03 +/- 4.7e-05 | 3.45e-03 +/- 2.2e-04 |
test_objective_compute_atf | +0.18 +/- 3.71 | +2.07e-05 +/- 4.18e-04 | 1.13e-02 +/- 3.0e-04 | 1.13e-02 +/- 2.9e-04 |
test_objective_jac_dshape_current | +3.93 +/- 14.50 | +5.79e-03 +/- 2.14e-02 | 1.53e-01 +/- 1.3e-02 | 1.47e-01 +/- 1.7e-02 |
test_objective_jac_atf | +1.61 +/- 6.59 | +1.37e-01 +/- 5.60e-01 | 8.63e+00 +/- 2.1e-01 | 8.50e+00 +/- 5.2e-01 |
test_perturb_1 | +0.44 +/- 14.81 | +4.91e-02 +/- 1.64e+00 | 1.11e+01 +/- 1.2e+00 | 1.11e+01 +/- 1.2e+00 |
test_perturb_2 | -0.49 +/- 3.93 | -9.37e-02 +/- 7.52e-01 | 1.90e+01 +/- 4.7e-01 | 1.91e+01 +/- 5.8e-01 | |
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | +0.49 +/- 1.39 | +9.01e-05 +/- 2.53e-04 | 1.83e-02 +/- 2.0e-04 | 1.82e-02 +/- 1.5e-04 |
test_build_transform_fft_midres | +2.23 +/- 0.79 | +2.51e-03 +/- 8.88e-04 | 1.15e-01 +/- 6.3e-04 | 1.12e-01 +/- 6.2e-04 |
-test_build_transform_fft_highres | +2.51 +/- 0.79 | +1.32e-02 +/- 4.14e-03 | 5.39e-01 +/- 3.1e-03 | 5.26e-01 +/- 2.8e-03 |
test_equilibrium_init_lowres | -0.12 +/- 1.14 | -9.11e-04 +/- 8.95e-03 | 7.85e-01 +/- 6.6e-03 | 7.86e-01 +/- 6.1e-03 |
test_equilibrium_init_medres | +0.44 +/- 0.74 | +5.19e-03 +/- 8.76e-03 | 1.20e+00 +/- 6.5e-03 | 1.19e+00 +/- 5.9e-03 |
test_equilibrium_init_highres | +1.53 +/- 0.77 | +4.53e-02 +/- 2.30e-02 | 3.01e+00 +/- 1.8e-02 | 2.97e+00 +/- 1.4e-02 |
test_objective_compile_dshape_current | +0.30 +/- 6.53 | +1.50e-02 +/- 3.31e-01 | 5.08e+00 +/- 2.4e-01 | 5.07e+00 +/- 2.2e-01 |
test_objective_compile_atf | +1.74 +/- 2.96 | +2.46e-01 +/- 4.17e-01 | 1.43e+01 +/- 2.8e-01 | 1.41e+01 +/- 3.1e-01 |
test_objective_compute_dshape_current | +0.35 +/- 2.27 | +1.12e-05 +/- 7.16e-05 | 3.16e-03 +/- 5.2e-05 | 3.15e-03 +/- 5.0e-05 |
test_objective_compute_atf | -1.19 +/- 4.23 | -1.32e-04 +/- 4.67e-04 | 1.09e-02 +/- 3.5e-04 | 1.10e-02 +/- 3.1e-04 |
test_objective_jac_dshape_current | +1.60 +/- 9.01 | +2.16e-03 +/- 1.22e-02 | 1.37e-01 +/- 1.0e-02 | 1.35e-01 +/- 6.9e-03 |
test_objective_jac_atf | +1.35 +/- 3.52 | +8.01e-02 +/- 2.09e-01 | 6.03e+00 +/- 2.0e-01 | 5.95e+00 +/- 7.3e-02 |
test_perturb_1 | +0.29 +/- 9.85 | +2.96e-02 +/- 1.01e+00 | 1.03e+01 +/- 7.1e-01 | 1.03e+01 +/- 7.3e-01 |
test_perturb_2 | +0.07 +/- 2.71 | +1.20e-02 +/- 4.74e-01 | 1.75e+01 +/- 3.1e-01 | 1.75e+01 +/- 3.6e-01 | |
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | -2.96 +/- 1.60 | -5.81e-04 +/- 3.15e-04 | 1.91e-02 +/- 2.5e-04 | 1.96e-02 +/- 1.9e-04 |
+test_build_transform_fft_midres | -3.15 +/- 0.89 | -3.67e-03 +/- 1.04e-03 | 1.13e-01 +/- 8.0e-04 | 1.17e-01 +/- 6.6e-04 |
+test_build_transform_fft_highres | -2.09 +/- 0.47 | -1.10e-02 +/- 2.46e-03 | 5.18e-01 +/- 1.7e-03 | 5.29e-01 +/- 1.8e-03 |
test_equilibrium_init_lowres | -0.88 +/- 0.92 | -7.45e-03 +/- 7.83e-03 | 8.42e-01 +/- 5.5e-03 | 8.49e-01 +/- 5.6e-03 |
test_equilibrium_init_medres | -1.97 +/- 0.96 | -2.53e-02 +/- 1.23e-02 | 1.26e+00 +/- 1.1e-02 | 1.29e+00 +/- 5.9e-03 |
+test_equilibrium_init_highres | -2.26 +/- 0.52 | -6.98e-02 +/- 1.59e-02 | 3.02e+00 +/- 9.8e-03 | 3.09e+00 +/- 1.3e-02 |
test_objective_compile_dshape_current | +0.06 +/- 6.68 | +3.15e-03 +/- 3.55e-01 | 5.32e+00 +/- 2.8e-01 | 5.32e+00 +/- 2.2e-01 |
test_objective_compile_atf | +1.42 +/- 5.67 | +2.26e-01 +/- 9.00e-01 | 1.61e+01 +/- 7.6e-01 | 1.59e+01 +/- 4.8e-01 |
test_objective_compute_dshape_current | -0.63 +/- 1.46 | -2.11e-05 +/- 4.90e-05 | 3.32e-03 +/- 3.6e-05 | 3.34e-03 +/- 3.4e-05 |
test_objective_compute_atf | -0.03 +/- 2.60 | -3.07e-06 +/- 2.93e-04 | 1.13e-02 +/- 2.0e-04 | 1.13e-02 +/- 2.1e-04 |
test_objective_jac_dshape_current | +1.79 +/- 16.56 | +2.50e-03 +/- 2.30e-02 | 1.42e-01 +/- 2.2e-02 | 1.39e-01 +/- 6.4e-03 |
test_objective_jac_atf | -0.56 +/- 1.75 | -4.04e-02 +/- 1.27e-01 | 7.21e+00 +/- 6.6e-02 | 7.25e+00 +/- 1.1e-01 |
test_perturb_1 | -1.19 +/- 10.69 | -1.30e-01 +/- 1.17e+00 | 1.08e+01 +/- 8.7e-01 | 1.09e+01 +/- 7.8e-01 |
test_perturb_2 | -1.91 +/- 3.44 | -3.63e-01 +/- 6.55e-01 | 1.87e+01 +/- 4.2e-01 | 1.90e+01 +/- 5.0e-01 | |
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | -4.09 +/- 1.86 | -6.61e-04 +/- 3.00e-04 | 1.55e-02 +/- 1.6e-04 | 1.62e-02 +/- 2.5e-04 |
test_build_transform_fft_midres | -1.34 +/- 1.15 | -1.30e-03 +/- 1.12e-03 | 9.55e-02 +/- 7.9e-04 | 9.68e-02 +/- 7.9e-04 |
test_build_transform_fft_highres | -0.30 +/- 0.81 | -1.38e-03 +/- 3.75e-03 | 4.64e-01 +/- 3.2e-03 | 4.66e-01 +/- 2.0e-03 |
test_equilibrium_init_lowres | -1.32 +/- 1.58 | -8.78e-03 +/- 1.05e-02 | 6.56e-01 +/- 6.7e-03 | 6.64e-01 +/- 8.0e-03 |
test_equilibrium_init_medres | -0.77 +/- 1.39 | -7.74e-03 +/- 1.39e-02 | 9.92e-01 +/- 8.7e-03 | 9.99e-01 +/- 1.1e-02 |
test_equilibrium_init_highres | -0.47 +/- 0.66 | -1.21e-02 +/- 1.70e-02 | 2.56e+00 +/- 1.1e-02 | 2.57e+00 +/- 1.3e-02 |
test_objective_compile_dshape_current | +1.06 +/- 8.04 | +4.37e-02 +/- 3.30e-01 | 4.15e+00 +/- 2.2e-01 | 4.11e+00 +/- 2.5e-01 |
test_objective_compile_atf | +1.47 +/- 6.60 | +1.35e-01 +/- 6.08e-01 | 9.34e+00 +/- 4.3e-01 | 9.21e+00 +/- 4.3e-01 |
test_objective_compute_dshape_current | +0.48 +/- 2.72 | +1.03e-05 +/- 5.88e-05 | 2.17e-03 +/- 3.8e-05 | 2.16e-03 +/- 4.5e-05 |
test_objective_compute_atf | +1.58 +/- 1.41 | +1.21e-04 +/- 1.08e-04 | 7.75e-03 +/- 4.7e-05 | 7.63e-03 +/- 9.7e-05 |
test_objective_jac_dshape_current | -1.20 +/- 10.14 | -5.48e-04 +/- 4.64e-03 | 4.52e-02 +/- 2.4e-03 | 4.57e-02 +/- 4.0e-03 |
test_objective_jac_atf | -0.21 +/- 6.56 | -4.90e-03 +/- 1.51e-01 | 2.30e+00 +/- 1.3e-01 | 2.30e+00 +/- 7.8e-02 |
test_perturb_1 | +1.67 +/- 13.12 | +1.42e-01 +/- 1.11e+00 | 8.63e+00 +/- 8.2e-01 | 8.49e+00 +/- 7.6e-01 |
test_perturb_2 | +3.10 +/- 3.81 | +4.41e-01 +/- 5.41e-01 | 1.46e+01 +/- 4.1e-01 | 1.42e+01 +/- 3.5e-01 | |
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | +0.87 +/- 0.89 | +1.35e-04 +/- 1.38e-04 | 1.57e-02 +/- 1.0e-04 | 1.55e-02 +/- 9.5e-05 |
test_build_transform_fft_midres | -0.38 +/- 1.38 | -3.65e-04 +/- 1.32e-03 | 9.52e-02 +/- 1.0e-03 | 9.55e-02 +/- 8.2e-04 |
test_build_transform_fft_highres | +0.41 +/- 0.92 | +1.92e-03 +/- 4.31e-03 | 4.71e-01 +/- 3.9e-03 | 4.69e-01 +/- 1.9e-03 |
test_equilibrium_init_lowres | +1.19 +/- 1.55 | +7.80e-03 +/- 1.02e-02 | 6.63e-01 +/- 8.6e-03 | 6.55e-01 +/- 5.4e-03 |
test_equilibrium_init_medres | +0.26 +/- 0.99 | +2.58e-03 +/- 9.97e-03 | 1.01e+00 +/- 8.0e-03 | 1.00e+00 +/- 5.9e-03 |
test_equilibrium_init_highres | -1.03 +/- 0.86 | -2.68e-02 +/- 2.23e-02 | 2.56e+00 +/- 1.8e-02 | 2.59e+00 +/- 1.3e-02 |
test_objective_compile_dshape_current | +0.11 +/- 7.71 | +4.78e-03 +/- 3.21e-01 | 4.17e+00 +/- 2.5e-01 | 4.16e+00 +/- 2.1e-01 |
test_objective_compile_atf | -1.10 +/- 6.66 | -1.02e-01 +/- 6.20e-01 | 9.21e+00 +/- 4.4e-01 | 9.31e+00 +/- 4.4e-01 |
test_objective_compute_dshape_current | +0.92 +/- 2.68 | +2.00e-05 +/- 5.82e-05 | 2.19e-03 +/- 4.7e-05 | 2.17e-03 +/- 3.5e-05 |
test_objective_compute_atf | +4.48 +/- 1.60 | +3.36e-04 +/- 1.20e-04 | 7.83e-03 +/- 7.2e-05 | 7.49e-03 +/- 9.6e-05 |
test_objective_jac_dshape_current | +1.87 +/- 7.64 | +8.48e-04 +/- 3.46e-03 | 4.61e-02 +/- 2.2e-03 | 4.53e-02 +/- 2.6e-03 |
test_objective_jac_atf | -6.82 +/- 5.39 | -1.68e-01 +/- 1.33e-01 | 2.29e+00 +/- 9.6e-02 | 2.46e+00 +/- 9.1e-02 |
test_perturb_1 | -0.67 +/- 13.16 | -5.81e-02 +/- 1.14e+00 | 8.61e+00 +/- 8.2e-01 | 8.67e+00 +/- 8.0e-01 |
test_perturb_2 | -0.04 +/- 4.72 | -5.81e-03 +/- 6.79e-01 | 1.44e+01 +/- 5.4e-01 | 1.44e+01 +/- 4.1e-01 | |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #648 +/- ##
=======================================
Coverage 94.93% 94.94%
=======================================
Files 80 80
Lines 19386 19411 +25
=======================================
+ Hits 18404 18429 +25
Misses 982 982
|
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | -4.18 +/- 2.08 | -8.37e-04 +/- 4.17e-04 | 1.92e-02 +/- 2.3e-04 | 2.00e-02 +/- 3.5e-04 |
test_build_transform_fft_midres | -0.25 +/- 0.72 | -2.81e-04 +/- 8.12e-04 | 1.13e-01 +/- 5.9e-04 | 1.13e-01 +/- 5.6e-04 |
test_build_transform_fft_highres | +1.90 +/- 0.72 | +9.78e-03 +/- 3.69e-03 | 5.23e-01 +/- 3.1e-03 | 5.13e-01 +/- 2.1e-03 |
test_equilibrium_init_lowres | -2.20 +/- 1.11 | -1.89e-02 +/- 9.54e-03 | 8.39e-01 +/- 6.3e-03 | 8.58e-01 +/- 7.2e-03 |
test_equilibrium_init_medres | -1.22 +/- 0.95 | -1.55e-02 +/- 1.21e-02 | 1.26e+00 +/- 9.5e-03 | 1.28e+00 +/- 7.4e-03 |
test_equilibrium_init_highres | -0.35 +/- 0.55 | -1.06e-02 +/- 1.68e-02 | 3.03e+00 +/- 1.1e-02 | 3.04e+00 +/- 1.3e-02 |
test_objective_compile_dshape_current | -1.63 +/- 6.58 | -8.77e-02 +/- 3.55e-01 | 5.31e+00 +/- 2.9e-01 | 5.39e+00 +/- 2.0e-01 |
test_objective_compile_atf | -1.61 +/- 5.38 | -2.65e-01 +/- 8.84e-01 | 1.62e+01 +/- 5.8e-01 | 1.64e+01 +/- 6.7e-01 |
test_objective_compute_dshape_current | +0.05 +/- 3.14 | +1.75e-06 +/- 1.07e-04 | 3.41e-03 +/- 7.4e-05 | 3.40e-03 +/- 7.7e-05 |
test_objective_compute_atf | +0.46 +/- 2.19 | +5.32e-05 +/- 2.52e-04 | 1.16e-02 +/- 1.6e-04 | 1.15e-02 +/- 2.0e-04 |
test_objective_jac_dshape_current | -2.66 +/- 13.45 | -3.79e-03 +/- 1.91e-02 | 1.39e-01 +/- 1.3e-02 | 1.42e-01 +/- 1.4e-02 |
test_objective_jac_atf | -6.16 +/- 3.47 | -4.68e-01 +/- 2.64e-01 | 7.14e+00 +/- 2.2e-01 | 7.61e+00 +/- 1.5e-01 |
test_perturb_1 | -3.77 +/- 12.17 | -4.25e-01 +/- 1.37e+00 | 1.09e+01 +/- 9.6e-01 | 1.13e+01 +/- 9.9e-01 |
test_perturb_2 | -0.31 +/- 4.49 | -5.93e-02 +/- 8.68e-01 | 1.93e+01 +/- 5.2e-01 | 1.93e+01 +/- 7.0e-01 | |
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | +1.23 +/- 5.53 | +1.90e-04 +/- 8.55e-04 | 1.56e-02 +/- 8.3e-04 | 1.54e-02 +/- 1.9e-04 |
test_build_transform_fft_midres | -0.31 +/- 1.33 | -2.95e-04 +/- 1.26e-03 | 9.48e-02 +/- 8.0e-04 | 9.51e-02 +/- 9.8e-04 |
test_build_transform_fft_highres | +0.43 +/- 1.10 | +1.99e-03 +/- 5.12e-03 | 4.69e-01 +/- 3.7e-03 | 4.67e-01 +/- 3.5e-03 |
test_equilibrium_init_lowres | +0.56 +/- 1.52 | +3.69e-03 +/- 1.00e-02 | 6.64e-01 +/- 7.4e-03 | 6.60e-01 +/- 6.7e-03 |
test_equilibrium_init_medres | -1.53 +/- 2.04 | -1.56e-02 +/- 2.08e-02 | 1.00e+00 +/- 1.3e-02 | 1.02e+00 +/- 1.7e-02 |
test_equilibrium_init_highres | -0.73 +/- 0.86 | -1.88e-02 +/- 2.23e-02 | 2.58e+00 +/- 1.3e-02 | 2.59e+00 +/- 1.8e-02 |
test_objective_compile_dshape_current | -2.06 +/- 7.61 | -8.79e-02 +/- 3.26e-01 | 4.19e+00 +/- 2.6e-01 | 4.28e+00 +/- 2.0e-01 |
test_objective_compile_atf | -1.57 +/- 6.68 | -1.48e-01 +/- 6.32e-01 | 9.31e+00 +/- 4.2e-01 | 9.46e+00 +/- 4.7e-01 |
test_objective_compute_dshape_current | +1.35 +/- 4.00 | +2.95e-05 +/- 8.71e-05 | 2.21e-03 +/- 7.6e-05 | 2.18e-03 +/- 4.2e-05 |
test_objective_compute_atf | +1.09 +/- 1.49 | +8.38e-05 +/- 1.15e-04 | 7.79e-03 +/- 9.8e-05 | 7.70e-03 +/- 5.9e-05 |
test_objective_jac_dshape_current | +1.18 +/- 11.63 | +5.32e-04 +/- 5.27e-03 | 4.58e-02 +/- 2.9e-03 | 4.53e-02 +/- 4.4e-03 |
test_objective_jac_atf | +3.41 +/- 11.45 | +7.82e-02 +/- 2.63e-01 | 2.37e+00 +/- 1.2e-01 | 2.29e+00 +/- 2.3e-01 |
test_perturb_1 | -0.75 +/- 12.61 | -6.52e-02 +/- 1.10e+00 | 8.64e+00 +/- 7.9e-01 | 8.70e+00 +/- 7.7e-01 |
test_perturb_2 | +0.06 +/- 4.85 | +8.09e-03 +/- 7.03e-01 | 1.45e+01 +/- 4.8e-01 | 1.45e+01 +/- 5.2e-01 | |
dpanici
reviewed
Nov 14, 2023
dpanici
reviewed
Nov 14, 2023
f0uriest
reviewed
Nov 14, 2023
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | +0.31 +/- 2.35 | +4.79e-05 +/- 3.64e-04 | 1.56e-02 +/- 1.7e-04 | 1.55e-02 +/- 3.2e-04 |
test_build_transform_fft_midres | +1.31 +/- 0.98 | +1.25e-03 +/- 9.36e-04 | 9.70e-02 +/- 7.6e-04 | 9.58e-02 +/- 5.5e-04 |
test_build_transform_fft_highres | -0.00 +/- 1.10 | -8.98e-06 +/- 5.20e-03 | 4.71e-01 +/- 3.1e-03 | 4.71e-01 +/- 4.2e-03 |
+test_equilibrium_init_lowres | -17.63 +/- 1.64 | -1.41e-01 +/- 1.31e-02 | 6.59e-01 +/- 6.1e-03 | 8.00e-01 +/- 1.2e-02 |
+test_equilibrium_init_medres | -29.10 +/- 0.88 | -4.15e-01 +/- 1.25e-02 | 1.01e+00 +/- 6.1e-03 | 1.43e+00 +/- 1.1e-02 |
+test_equilibrium_init_highres | -38.56 +/- 0.65 | -1.62e+00 +/- 2.75e-02 | 2.58e+00 +/- 1.7e-02 | 4.21e+00 +/- 2.1e-02 |
test_objective_compile_dshape_current | +0.19 +/- 8.49 | +7.93e-03 +/- 3.56e-01 | 4.20e+00 +/- 2.4e-01 | 4.20e+00 +/- 2.6e-01 |
test_objective_compile_atf | +0.31 +/- 7.04 | +2.87e-02 +/- 6.49e-01 | 9.25e+00 +/- 3.6e-01 | 9.22e+00 +/- 5.4e-01 |
test_objective_compute_dshape_current | +1.16 +/- 3.24 | +2.55e-05 +/- 7.11e-05 | 2.22e-03 +/- 2.3e-05 | 2.19e-03 +/- 6.7e-05 |
test_objective_compute_atf | +2.94 +/- 2.22 | +2.24e-04 +/- 1.69e-04 | 7.86e-03 +/- 1.3e-04 | 7.64e-03 +/- 1.1e-04 |
test_objective_jac_dshape_current | +1.83 +/- 14.77 | +8.48e-04 +/- 6.84e-03 | 4.72e-02 +/- 6.2e-03 | 4.63e-02 +/- 2.9e-03 |
test_objective_jac_atf | -2.64 +/- 9.79 | -6.23e-02 +/- 2.31e-01 | 2.29e+00 +/- 1.8e-01 | 2.36e+00 +/- 1.4e-01 |
test_perturb_1 | +0.74 +/- 13.58 | +6.43e-02 +/- 1.17e+00 | 8.70e+00 +/- 7.9e-01 | 8.64e+00 +/- 8.7e-01 |
test_perturb_2 | +0.58 +/- 3.90 | +8.41e-02 +/- 5.67e-01 | 1.46e+01 +/- 3.3e-01 | 1.45e+01 +/- 4.6e-01 | |
|
don't include aliases as extra entries in docs, modify write_variables.py to do so, check for functools as module add new column for aliases |
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | +0.15 +/- 1.53 | +2.26e-05 +/- 2.33e-04 | 1.53e-02 +/- 1.8e-04 | 1.53e-02 +/- 1.4e-04 |
test_build_transform_fft_midres | -0.28 +/- 0.81 | -2.59e-04 +/- 7.58e-04 | 9.37e-02 +/- 4.6e-04 | 9.40e-02 +/- 6.0e-04 |
test_build_transform_fft_highres | -0.03 +/- 0.64 | -1.16e-04 +/- 2.95e-03 | 4.63e-01 +/- 2.3e-03 | 4.63e-01 +/- 1.8e-03 |
test_equilibrium_init_lowres | +0.77 +/- 1.73 | +6.07e-03 +/- 1.36e-02 | 7.93e-01 +/- 1.1e-02 | 7.87e-01 +/- 8.1e-03 |
test_equilibrium_init_medres | +0.35 +/- 0.97 | +4.97e-03 +/- 1.37e-02 | 1.41e+00 +/- 1.0e-02 | 1.41e+00 +/- 9.0e-03 |
test_equilibrium_init_highres | -0.20 +/- 0.92 | -8.24e-03 +/- 3.84e-02 | 4.18e+00 +/- 3.3e-02 | 4.19e+00 +/- 2.0e-02 |
test_objective_compile_dshape_current | -0.34 +/- 7.93 | -1.40e-02 +/- 3.28e-01 | 4.12e+00 +/- 1.8e-01 | 4.13e+00 +/- 2.7e-01 |
test_objective_compile_atf | +0.11 +/- 5.97 | +1.05e-02 +/- 5.50e-01 | 9.23e+00 +/- 4.2e-01 | 9.21e+00 +/- 3.5e-01 |
test_objective_compute_dshape_current | +1.18 +/- 2.19 | +2.55e-05 +/- 4.73e-05 | 2.19e-03 +/- 3.0e-05 | 2.16e-03 +/- 3.6e-05 |
test_objective_compute_atf | +0.37 +/- 1.05 | +2.82e-05 +/- 7.95e-05 | 7.63e-03 +/- 5.8e-05 | 7.60e-03 +/- 5.5e-05 |
test_objective_jac_dshape_current | -0.40 +/- 7.13 | -1.81e-04 +/- 3.25e-03 | 4.54e-02 +/- 2.4e-03 | 4.56e-02 +/- 2.2e-03 |
test_objective_jac_atf | +0.87 +/- 3.48 | +1.97e-02 +/- 7.88e-02 | 2.28e+00 +/- 5.3e-02 | 2.27e+00 +/- 5.8e-02 |
test_perturb_1 | -0.11 +/- 14.84 | -9.75e-03 +/- 1.26e+00 | 8.51e+00 +/- 8.8e-01 | 8.52e+00 +/- 9.0e-01 |
test_perturb_2 | -0.34 +/- 4.41 | -4.92e-02 +/- 6.35e-01 | 1.44e+01 +/- 5.0e-01 | 1.44e+01 +/- 4.0e-01 | |
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | +0.33 +/- 1.85 | +5.18e-05 +/- 2.86e-04 | 1.55e-02 +/- 2.0e-04 | 1.55e-02 +/- 2.0e-04 |
test_build_transform_fft_midres | -0.13 +/- 1.16 | -1.20e-04 +/- 1.10e-03 | 9.44e-02 +/- 8.0e-04 | 9.45e-02 +/- 7.5e-04 |
test_build_transform_fft_highres | -0.01 +/- 0.81 | -5.19e-05 +/- 3.75e-03 | 4.65e-01 +/- 3.2e-03 | 4.65e-01 +/- 2.0e-03 |
test_equilibrium_init_lowres | +0.56 +/- 0.89 | +4.38e-03 +/- 7.01e-03 | 7.92e-01 +/- 5.7e-03 | 7.88e-01 +/- 4.0e-03 |
test_equilibrium_init_medres | +0.26 +/- 1.09 | +3.65e-03 +/- 1.54e-02 | 1.41e+00 +/- 1.0e-02 | 1.41e+00 +/- 1.2e-02 |
test_equilibrium_init_highres | -0.77 +/- 0.59 | -3.22e-02 +/- 2.47e-02 | 4.16e+00 +/- 2.0e-02 | 4.19e+00 +/- 1.4e-02 |
test_objective_compile_dshape_current | -0.04 +/- 8.50 | -1.57e-03 +/- 3.50e-01 | 4.12e+00 +/- 2.4e-01 | 4.12e+00 +/- 2.5e-01 |
test_objective_compile_atf | +1.64 +/- 6.43 | +1.51e-01 +/- 5.93e-01 | 9.37e+00 +/- 4.6e-01 | 9.22e+00 +/- 3.8e-01 |
test_objective_compute_dshape_current | +6.65 +/- 6.62 | +1.45e-04 +/- 1.44e-04 | 2.32e-03 +/- 1.4e-04 | 2.18e-03 +/- 3.0e-05 |
test_objective_compute_atf | +1.66 +/- 1.21 | +1.27e-04 +/- 9.29e-05 | 7.80e-03 +/- 5.8e-05 | 7.67e-03 +/- 7.2e-05 |
test_objective_jac_dshape_current | -0.91 +/- 10.53 | -4.17e-04 +/- 4.83e-03 | 4.54e-02 +/- 4.1e-03 | 4.58e-02 +/- 2.6e-03 |
test_objective_jac_atf | +0.90 +/- 4.69 | +2.02e-02 +/- 1.05e-01 | 2.27e+00 +/- 5.1e-02 | 2.25e+00 +/- 9.2e-02 |
test_perturb_1 | +0.57 +/- 12.97 | +4.86e-02 +/- 1.10e+00 | 8.54e+00 +/- 7.7e-01 | 8.49e+00 +/- 7.9e-01 |
test_perturb_2 | +0.84 +/- 4.68 | +1.20e-01 +/- 6.66e-01 | 1.43e+01 +/- 4.3e-01 | 1.42e+01 +/- 5.1e-01 | |
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | -0.01 +/- 1.55 | -8.47e-07 +/- 2.39e-04 | 1.55e-02 +/- 1.9e-04 | 1.55e-02 +/- 1.5e-04 |
test_build_transform_fft_midres | +0.05 +/- 1.00 | +4.50e-05 +/- 9.41e-04 | 9.44e-02 +/- 6.1e-04 | 9.43e-02 +/- 7.2e-04 |
test_build_transform_fft_highres | +1.08 +/- 0.59 | +5.01e-03 +/- 2.74e-03 | 4.68e-01 +/- 1.8e-03 | 4.63e-01 +/- 2.1e-03 |
test_equilibrium_init_lowres | -0.46 +/- 1.15 | -3.70e-03 +/- 9.21e-03 | 7.98e-01 +/- 7.4e-03 | 8.02e-01 +/- 5.5e-03 |
test_equilibrium_init_medres | +0.14 +/- 0.75 | +2.04e-03 +/- 1.07e-02 | 1.42e+00 +/- 7.0e-03 | 1.42e+00 +/- 8.1e-03 |
test_equilibrium_init_highres | -0.20 +/- 0.93 | -8.22e-03 +/- 3.90e-02 | 4.19e+00 +/- 2.6e-02 | 4.20e+00 +/- 2.9e-02 |
test_objective_compile_dshape_current | +0.10 +/- 8.56 | +4.11e-03 +/- 3.56e-01 | 4.17e+00 +/- 2.6e-01 | 4.16e+00 +/- 2.5e-01 |
test_objective_compile_atf | +0.26 +/- 6.91 | +2.42e-02 +/- 6.41e-01 | 9.30e+00 +/- 5.3e-01 | 9.28e+00 +/- 3.7e-01 |
test_objective_compute_dshape_current | +1.23 +/- 2.47 | +2.70e-05 +/- 5.42e-05 | 2.22e-03 +/- 4.3e-05 | 2.20e-03 +/- 3.3e-05 |
test_objective_compute_atf | -1.79 +/- 0.95 | -1.38e-04 +/- 7.26e-05 | 7.54e-03 +/- 4.0e-05 | 7.68e-03 +/- 6.1e-05 |
test_objective_jac_dshape_current | +1.38 +/- 13.19 | +6.26e-04 +/- 5.97e-03 | 4.59e-02 +/- 4.0e-03 | 4.53e-02 +/- 4.5e-03 |
test_objective_jac_atf | -1.85 +/- 4.75 | -4.43e-02 +/- 1.14e-01 | 2.35e+00 +/- 9.5e-02 | 2.40e+00 +/- 6.3e-02 |
test_perturb_1 | -0.56 +/- 13.25 | -4.88e-02 +/- 1.15e+00 | 8.61e+00 +/- 8.4e-01 | 8.66e+00 +/- 7.8e-01 |
test_perturb_2 | -1.07 +/- 4.35 | -1.56e-01 +/- 6.33e-01 | 1.44e+01 +/- 5.1e-01 | 1.46e+01 +/- 3.8e-01 | |
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | -4.58 +/- 3.11 | -7.40e-04 +/- 5.02e-04 | 1.54e-02 +/- 1.6e-04 | 1.61e-02 +/- 4.8e-04 |
test_build_transform_fft_midres | -1.61 +/- 1.27 | -1.54e-03 +/- 1.21e-03 | 9.37e-02 +/- 7.4e-04 | 9.52e-02 +/- 9.5e-04 |
test_build_transform_fft_highres | -0.84 +/- 0.87 | -3.92e-03 +/- 4.04e-03 | 4.63e-01 +/- 3.3e-03 | 4.67e-01 +/- 2.4e-03 |
test_equilibrium_init_lowres | -2.91 +/- 2.33 | -2.38e-02 +/- 1.91e-02 | 7.94e-01 +/- 6.5e-03 | 8.18e-01 +/- 1.8e-02 |
test_equilibrium_init_medres | +0.07 +/- 1.29 | +1.00e-03 +/- 1.85e-02 | 1.43e+00 +/- 1.2e-02 | 1.43e+00 +/- 1.4e-02 |
test_equilibrium_init_highres | -1.14 +/- 0.90 | -4.80e-02 +/- 3.79e-02 | 4.17e+00 +/- 3.0e-02 | 4.22e+00 +/- 2.3e-02 |
test_objective_compile_dshape_current | -1.37 +/- 9.00 | -5.76e-02 +/- 3.79e-01 | 4.15e+00 +/- 2.4e-01 | 4.21e+00 +/- 3.0e-01 |
test_objective_compile_atf | -2.54 +/- 6.24 | -2.42e-01 +/- 5.93e-01 | 9.26e+00 +/- 4.1e-01 | 9.50e+00 +/- 4.3e-01 |
test_objective_compute_dshape_current | -0.07 +/- 2.75 | -1.48e-06 +/- 5.97e-05 | 2.17e-03 +/- 4.1e-05 | 2.17e-03 +/- 4.4e-05 |
test_objective_compute_atf | -2.73 +/- 1.42 | -2.13e-04 +/- 1.10e-04 | 7.59e-03 +/- 7.2e-05 | 7.80e-03 +/- 8.4e-05 |
test_objective_jac_dshape_current | +1.83 +/- 11.35 | +8.25e-04 +/- 5.12e-03 | 4.60e-02 +/- 3.5e-03 | 4.52e-02 +/- 3.7e-03 |
test_objective_jac_atf | -1.26 +/- 7.57 | -2.95e-02 +/- 1.76e-01 | 2.30e+00 +/- 7.6e-02 | 2.33e+00 +/- 1.6e-01 |
test_perturb_1 | +0.44 +/- 12.88 | +3.78e-02 +/- 1.11e+00 | 8.64e+00 +/- 7.6e-01 | 8.60e+00 +/- 8.1e-01 |
test_perturb_2 | +0.88 +/- 4.26 | +1.29e-01 +/- 6.22e-01 | 1.47e+01 +/- 3.6e-01 | 1.46e+01 +/- 5.1e-01 | |
f0uriest
approved these changes
Nov 17, 2023
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | +0.03 +/- 2.94 | +4.65e-06 +/- 4.62e-04 | 1.57e-02 +/- 2.6e-04 | 1.57e-02 +/- 3.8e-04 |
test_build_transform_fft_midres | +1.00 +/- 1.18 | +9.59e-04 +/- 1.13e-03 | 9.68e-02 +/- 9.9e-04 | 9.59e-02 +/- 5.3e-04 |
test_build_transform_fft_highres | +1.08 +/- 1.05 | +5.05e-03 +/- 4.93e-03 | 4.74e-01 +/- 3.9e-03 | 4.69e-01 +/- 3.0e-03 |
test_equilibrium_init_lowres | -0.55 +/- 1.28 | -4.48e-03 +/- 1.05e-02 | 8.11e-01 +/- 8.3e-03 | 8.16e-01 +/- 6.4e-03 |
test_equilibrium_init_medres | +0.69 +/- 1.14 | +9.88e-03 +/- 1.64e-02 | 1.45e+00 +/- 1.1e-02 | 1.44e+00 +/- 1.2e-02 |
test_equilibrium_init_highres | -1.10 +/- 0.81 | -4.70e-02 +/- 3.45e-02 | 4.22e+00 +/- 2.6e-02 | 4.27e+00 +/- 2.3e-02 |
test_objective_compile_dshape_current | -0.61 +/- 8.02 | -2.61e-02 +/- 3.42e-01 | 4.24e+00 +/- 2.4e-01 | 4.27e+00 +/- 2.4e-01 |
test_objective_compile_atf | -0.18 +/- 7.75 | -1.74e-02 +/- 7.33e-01 | 9.44e+00 +/- 5.2e-01 | 9.46e+00 +/- 5.2e-01 |
test_objective_compute_dshape_current | +1.69 +/- 4.85 | +3.68e-05 +/- 1.06e-04 | 2.21e-03 +/- 9.3e-05 | 2.18e-03 +/- 5.0e-05 |
test_objective_compute_atf | +2.07 +/- 2.92 | +1.61e-04 +/- 2.27e-04 | 7.95e-03 +/- 1.1e-04 | 7.79e-03 +/- 2.0e-04 |
test_objective_jac_dshape_current | +0.08 +/- 12.70 | +3.50e-05 +/- 5.82e-03 | 4.58e-02 +/- 3.4e-03 | 4.58e-02 +/- 4.7e-03 |
test_objective_jac_atf | -2.49 +/- 4.69 | -5.87e-02 +/- 1.10e-01 | 2.29e+00 +/- 5.9e-02 | 2.35e+00 +/- 9.3e-02 |
test_perturb_1 | +0.12 +/- 14.03 | +1.05e-02 +/- 1.23e+00 | 8.80e+00 +/- 9.2e-01 | 8.79e+00 +/- 8.2e-01 |
test_perturb_2 | -0.77 +/- 5.09 | -1.14e-01 +/- 7.57e-01 | 1.48e+01 +/- 4.8e-01 | 1.49e+01 +/- 5.9e-01 | |
|
@f0uriest in the docs, the aliases column gets cut off a bit depending on screen size. Should we care about that? I talked with dario about adding a line break to the f_c label so there's more space available but the code seems a bit annoying for that. |
|
If there's any easy fix that would be good but it's not essential/urgent |
|
Okay then I'll just merge it for now since it will probably take more time than it's worth. And for @unalmis 's comment from before: that's a good idea but I think we'll just keep this PR limited to the API since it's taken me so long already and add in more features later. |
dpanici
added a commit
that referenced
this pull request
Jun 25, 2024
A few compute functions do a lot of work to compute the same thing as another, sometimes with slightly different math. It's better to just alias them to the other so that there is less math to check as mentioned [here](#648 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides API for aliases of computed quantities. Additionally finds permutations of some specified quantities and assigns them as aliases. The aliases are then added to
data_index