replacing patch with update during allocation #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current allocation logic with PATCH the .status.state of a GameServer Custom Resource with the new "Active" state. However, there are cases in which this might create issues since PATCH does not check the current state of the object. For example, the object might have been deleted or crashed and the cache might have not been updated. This will lead to the allocation API service returning an invalid active game server to the caller. To prevent this, we are switching the Patch with Update which will fail if the object's state has changed.
For the time being, this will require the customer to implement a retry logic till we can implement some retry logic ourselves, maybe as part of #7.