Convert system set to base set to fix bug with egui feature #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plonq
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14
I found that when the exit condition was set to
OnPrimaryClosed, as soon as the run condition returned false, thecheck_egui_wants_focussystem stopped executing. I can see how this makes sense, because the system was set to run beforePanOrbitCameraSystemSetwhich is now not running. But I am not sure if that's actually how Bevy works. Additionally, it does run regardless ifOnAllClosedexit condition is used. Whatever the cause may be, using a base set instead works as expected. Base sets are also the only example of system sets I can find in the official examples, which may hint at something...