Handle empty Hit'n'Run torrent list

PoLaKoSz · Nov 16, 2020 · 9a3a0f8 · 9a3a0f8
1 parent 027c6f9
commit 9a3a0f8
Show file tree

Hide file tree

Showing 5 changed files with 377 additions and 2 deletions.
diff --git a/src/PoLaKoSz.Ncore/Parsers/HitAndRunParser.cs b/src/PoLaKoSz.Ncore/Parsers/HitAndRunParser.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using System.Threading.Tasks;
 using AngleSharp;
 using AngleSharp.Dom;
@@ -32,6 +33,11 @@ internal async Task<IEnumerable<HitAndRunTorrent>> ExtractResultsFromAsync(strin
                 throw new DeprecatedWrapperException("Couldn't find the Hit-And-Run torrent nodes!", container);
             }
 
+            if (NoHitAndRun(torrentNodes))
+            {
+                return torrents;
+            }
+
             DateTime currentTime = DateTime.Now;
             foreach (IElement torrentNode in torrentNodes)
             {
@@ -48,6 +54,12 @@ internal async Task<IEnumerable<HitAndRunTorrent>> ExtractResultsFromAsync(strin
             return torrents;
         }
 
+        private bool NoHitAndRun(IHtmlCollection<IElement> torrentNodes)
+        {
+            return torrentNodes.Count() == 1
+                && torrentNodes.First().TextContent == "Az általad letöltött anyagokat a szabályoknak megfelelően visszaosztottad, a listád ennek köszönhetően üres.";
+        }
+
         private HitAndRunTorrent ParseAsTorrent(IElement torrentNode, DateTime currentTime)
         {
             IElement nameNode = torrentNode.QuerySelector("div.hnr_tname a nobr");

diff --git a/src/PoLaKoSz.Ncore/PoLaKoSz.Ncore.csproj b/src/PoLaKoSz.Ncore/PoLaKoSz.Ncore.csproj
@@ -12,9 +12,9 @@
     <PackageLicenseUrl>https://github.com/PoLaKoSz/nCore/LICENSE</PackageLicenseUrl>
     <PackageId>PoLaKoSz.Ncore</PackageId>
     <Product>nCore</Product>
-    <PackageReleaseNotes>First stable release. The enty point to the library is the PoLaKoSz.Ncore.NcoreClient class.</PackageReleaseNotes>
+    <PackageReleaseNotes>Handle empty Hit'n'Run list. The enty point to the library is the PoLaKoSz.Ncore.NcoreClient class.</PackageReleaseNotes>
     <Description>nCore.cc is the largest hungarian torrent side. This .NET Core 2.1 library helps to access its content (Torrent details, user Hit'n'Runs, Search for Torrent).</Description>
-    <Version>1.0.1</Version>
+    <Version>1.1.0</Version>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">

diff --git a/tests/Integration/EndPoints/HitAndRunEndPointTests.cs b/tests/Integration/EndPoints/HitAndRunEndPointTests.cs
@@ -79,5 +79,15 @@ public async Task ListFirstTorrentRatioParsedCorrectly()
 
             Assert.That(firstTorrent.Ratio, Is.EqualTo(0.013f));
         }
+
+        [Test]
+        public async Task ListReturnsEmptyResultWhenNoHitAndRun()
+        {
+            SetServerResponse("no-torrent");
+
+            IEnumerable<HitAndRunTorrent> torrents = await endPoint.List();
+
+            Assert.That(torrents.Count(), Is.EqualTo(0));
+        }
     }
 }
diff --git a/tests/Integration/Integration.csproj b/tests/Integration/Integration.csproj
@@ -41,6 +41,9 @@
     <None Update="StaticResources\HitAndRunEndPoint\multiple-torrents.html">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
+    <None Update="StaticResources\HitAndRunEndPoint\no-torrent.html">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
     <None Update="StaticResources\TorrentEndPoint\movie.html">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>