diff --git a/registration/CMakeLists.txt b/registration/CMakeLists.txt index f2a7df2fe03..0cb0b997549 100644 --- a/registration/CMakeLists.txt +++ b/registration/CMakeLists.txt @@ -83,7 +83,6 @@ if(build) "include/pcl/${SUBSYS_NAME}/impl/correspondence_estimation_normal_shooting.hpp" "include/pcl/${SUBSYS_NAME}/impl/correspondence_estimation_backprojection.hpp" "include/pcl/${SUBSYS_NAME}/impl/correspondence_estimation_organized_projection.hpp" - "include/pcl/${SUBSYS_NAME}/impl/correspondence_rejection.hpp" "include/pcl/${SUBSYS_NAME}/impl/correspondence_rejection_distance.hpp" "include/pcl/${SUBSYS_NAME}/impl/correspondence_rejection_median_distance.hpp" "include/pcl/${SUBSYS_NAME}/impl/correspondence_rejection_surface_normal.hpp" diff --git a/registration/include/pcl/registration/correspondence_estimation.h b/registration/include/pcl/registration/correspondence_estimation.h index bbcf9c46848..25226024fa2 100644 --- a/registration/include/pcl/registration/correspondence_estimation.h +++ b/registration/include/pcl/registration/correspondence_estimation.h @@ -108,20 +108,6 @@ namespace pcl /** \brief Empty destructor */ virtual ~CorrespondenceEstimationBase () {} - /** \brief Provide a pointer to the input source - * (e.g., the point cloud that we want to align to the target) - * - * \param[in] cloud the input point cloud source - */ - PCL_DEPRECATED ("[pcl::registration::CorrespondenceEstimationBase::setInputCloud] setInputCloud is deprecated. Please use setInputSource instead.") - void - setInputCloud (const PointCloudSourceConstPtr &cloud); - - /** \brief Get a pointer to the input point cloud dataset target. */ - PCL_DEPRECATED ("[pcl::registration::CorrespondenceEstimationBase::getInputCloud] getInputCloud is deprecated. Please use getInputSource instead.") - PointCloudSourceConstPtr const - getInputCloud (); - /** \brief Provide a pointer to the input source * (e.g., the point cloud that we want to align to the target) * diff --git a/registration/include/pcl/registration/correspondence_rejection.h b/registration/include/pcl/registration/correspondence_rejection.h index ee6ad53b466..3fec679fc8a 100644 --- a/registration/include/pcl/registration/correspondence_rejection.h +++ b/registration/include/pcl/registration/correspondence_rejection.h @@ -246,19 +246,6 @@ namespace pcl /** \brief Empty destructor */ virtual ~DataContainer () {} - /** \brief Provide a source point cloud dataset (must contain XYZ - * data!), used to compute the correspondence distance. - * \param[in] cloud a cloud containing XYZ data - */ - PCL_DEPRECATED ("[pcl::registration::DataContainer::setInputCloud] setInputCloud is deprecated. Please use setInputSource instead.") - void - setInputCloud (const PointCloudConstPtr &cloud); - - /** \brief Get a pointer to the input point cloud dataset target. */ - PCL_DEPRECATED ("[pcl::registration::DataContainer::getInputCloud] getInputCloud is deprecated. Please use getInputSource instead.") - PointCloudConstPtr const - getInputCloud (); - /** \brief Provide a source point cloud dataset (must contain XYZ * data!), used to compute the correspondence distance. * \param[in] cloud a cloud containing XYZ data @@ -418,7 +405,5 @@ namespace pcl } } -#include - #endif /* PCL_REGISTRATION_CORRESPONDENCE_REJECTION_H_ */ diff --git a/registration/include/pcl/registration/correspondence_rejection_sample_consensus.h b/registration/include/pcl/registration/correspondence_rejection_sample_consensus.h index 6267ade00a4..fe9bb0ba727 100644 --- a/registration/include/pcl/registration/correspondence_rejection_sample_consensus.h +++ b/registration/include/pcl/registration/correspondence_rejection_sample_consensus.h @@ -97,18 +97,6 @@ namespace pcl getRemainingCorrespondences (const pcl::Correspondences& original_correspondences, pcl::Correspondences& remaining_correspondences); - /** \brief Provide a source point cloud dataset (must contain XYZ data!) - * \param[in] cloud a cloud containing XYZ data - */ - PCL_DEPRECATED ("[pcl::registration::CorrespondenceRejectorSampleConsensus::setInputCloud] setInputCloud is deprecated. Please use setInputSource instead.") - virtual void - setInputCloud (const PointCloudConstPtr &cloud); - - /** \brief Get a pointer to the input point cloud dataset target. */ - PCL_DEPRECATED ("[pcl::registration::CorrespondenceRejectorSampleConsensus::getInputCloud] getInputCloud is deprecated. Please use getInputSource instead.") - PointCloudConstPtr const - getInputCloud (); - /** \brief Provide a source point cloud dataset (must contain XYZ data!) * \param[in] cloud a cloud containing XYZ data */ @@ -122,13 +110,6 @@ namespace pcl inline PointCloudConstPtr const getInputSource () { return (input_); } - /** \brief Provide a target point cloud dataset (must contain XYZ data!) - * \param[in] cloud a cloud containing XYZ data - */ - PCL_DEPRECATED ("[pcl::registration::CorrespondenceRejectorSampleConsensus::setTargetCloud] setTargetCloud is deprecated. Please use setInputTarget instead.") - virtual void - setTargetCloud (const PointCloudConstPtr &cloud); - /** \brief Provide a target point cloud dataset (must contain XYZ data!) * \param[in] cloud a cloud containing XYZ data */ @@ -181,26 +162,12 @@ namespace pcl inline double getInlierThreshold () { return inlier_threshold_; }; - /** \brief Set the maximum number of iterations. - * \param[in] max_iterations Maximum number if iterations to run - */ - PCL_DEPRECATED ("[pcl::registration::CorrespondenceRejectorSampleConsensus::setMaxIterations] setMaxIterations is deprecated. Please use setMaximumIterations instead.") - void - setMaxIterations (int max_iterations); - /** \brief Set the maximum number of iterations. * \param[in] max_iterations Maximum number if iterations to run */ inline void setMaximumIterations (int max_iterations) { max_iterations_ = std::max (max_iterations, 0); } - /** \brief Get the maximum number of iterations. - * \return max_iterations Maximum number if iterations to run - */ - PCL_DEPRECATED ("[pcl::registration::CorrespondenceRejectorSampleConsensus::getMaxIterations] getMaxIterations is deprecated. Please use getMaximumIterations instead.") - int - getMaxIterations (); - /** \brief Get the maximum number of iterations. * \return max_iterations Maximum number if iterations to run */ diff --git a/registration/include/pcl/registration/gicp.h b/registration/include/pcl/registration/gicp.h index 361e5043f91..f7d6e31590b 100644 --- a/registration/include/pcl/registration/gicp.h +++ b/registration/include/pcl/registration/gicp.h @@ -120,13 +120,6 @@ namespace pcl boost::bind (&GeneralizedIterativeClosestPoint::estimateRigidTransformationBFGS, this, _1, _2, _3, _4, _5); } - - /** \brief Provide a pointer to the input dataset - * \param cloud the const boost shared pointer to a PointCloud message - */ - PCL_DEPRECATED ("[pcl::registration::GeneralizedIterativeClosestPoint::setInputCloud] setInputCloud is deprecated. Please use setInputSource instead.") - void - setInputCloud (const PointCloudSourceConstPtr &cloud); /** \brief Provide a pointer to the input dataset * \param cloud the const boost shared pointer to a PointCloud message diff --git a/registration/include/pcl/registration/impl/correspondence_estimation.hpp b/registration/include/pcl/registration/impl/correspondence_estimation.hpp index bdc2e87bfff..3eae7d1fe73 100644 --- a/registration/include/pcl/registration/impl/correspondence_estimation.hpp +++ b/registration/include/pcl/registration/impl/correspondence_estimation.hpp @@ -43,20 +43,6 @@ #include #include -/////////////////////////////////////////////////////////////////////////////////////////// -template void -pcl::registration::CorrespondenceEstimationBase::setInputCloud (const typename pcl::registration::CorrespondenceEstimationBase::PointCloudSourceConstPtr &cloud) -{ - setInputSource (cloud); -} - -/////////////////////////////////////////////////////////////////////////////////////////// -template typename pcl::registration::CorrespondenceEstimationBase::PointCloudSourceConstPtr const -pcl::registration::CorrespondenceEstimationBase::getInputCloud () -{ - return (getInputSource ()); -} - /////////////////////////////////////////////////////////////////////////////////////////// template void pcl::registration::CorrespondenceEstimationBase::setInputTarget ( diff --git a/registration/include/pcl/registration/impl/correspondence_rejection.hpp b/registration/include/pcl/registration/impl/correspondence_rejection.hpp deleted file mode 100644 index 7c89862b0d8..00000000000 --- a/registration/include/pcl/registration/impl/correspondence_rejection.hpp +++ /dev/null @@ -1,58 +0,0 @@ -/* - * Software License Agreement (BSD License) - * - * Point Cloud Library (PCL) - www.pointclouds.org - * Copyright (c) 2012-, Open Perception, Inc. - * - * All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * - * * Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * * Redistributions in binary form must reproduce the above - * copyright notice, this list of conditions and the following - * disclaimer in the documentation and/or other materials provided - * with the distribution. - * * Neither the name of the copyright holder(s) nor the names of its - * contributors may be used to endorse or promote products derived - * from this software without specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS - * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT - * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS - * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE - * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, - * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, - * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; - * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER - * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT - * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN - * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE - * POSSIBILITY OF SUCH DAMAGE. - * - */ - -#ifndef PCL_REGISTRATION_CORRESPONDENCE_REJECTION_IMPL_HPP_ -#define PCL_REGISTRATION_CORRESPONDENCE_REJECTION_IMPL_HPP_ - -/////////////////////////////////////////////////////////////////////////////////////////// -template void -pcl::registration::DataContainer::setInputCloud (const typename pcl::registration::DataContainer::PointCloudConstPtr &cloud) -{ - //input_ = cloud; - setInputSource (cloud); -} - -/////////////////////////////////////////////////////////////////////////////////////////// -template typename pcl::registration::DataContainer::PointCloudConstPtr const -pcl::registration::DataContainer::getInputCloud () -{ - return (getInputSource ()); - //return (input_); -} - -#endif // PCL_REGISTRATION_CORRESPONDENCE_REJECTION_IMPL_HPP_ - diff --git a/registration/include/pcl/registration/impl/correspondence_rejection_sample_consensus.hpp b/registration/include/pcl/registration/impl/correspondence_rejection_sample_consensus.hpp index 7ab5a2d9b92..6b96a1b67e3 100644 --- a/registration/include/pcl/registration/impl/correspondence_rejection_sample_consensus.hpp +++ b/registration/include/pcl/registration/impl/correspondence_rejection_sample_consensus.hpp @@ -42,44 +42,6 @@ #include -/////////////////////////////////////////////////////////////////////////////////////////// -template void -pcl::registration::CorrespondenceRejectorSampleConsensus::setInputCloud ( - const typename pcl::registration::CorrespondenceRejectorSampleConsensus::PointCloudConstPtr &cloud) -{ - setInputSource (cloud); -} - -/////////////////////////////////////////////////////////////////////////////////////////// -template typename pcl::registration::CorrespondenceRejectorSampleConsensus::PointCloudConstPtr const -pcl::registration::CorrespondenceRejectorSampleConsensus::getInputCloud () -{ - return (getInputSource ()); -} - -/////////////////////////////////////////////////////////////////////////////////////////// -template void -pcl::registration::CorrespondenceRejectorSampleConsensus::setTargetCloud ( - const typename pcl::registration::CorrespondenceRejectorSampleConsensus::PointCloudConstPtr &cloud) -{ - setInputTarget (cloud); -} - -/////////////////////////////////////////////////////////////////////////////////////////// -template void -pcl::registration::CorrespondenceRejectorSampleConsensus::setMaxIterations ( - int max_iterations) -{ - setMaximumIterations (max_iterations); -} - -/////////////////////////////////////////////////////////////////////////////////////////// -template int -pcl::registration::CorrespondenceRejectorSampleConsensus::getMaxIterations () -{ - return (getMaximumIterations ()); -} - /////////////////////////////////////////////////////////////////////////////////////////// template void pcl::registration::CorrespondenceRejectorSampleConsensus::getRemainingCorrespondences ( diff --git a/registration/include/pcl/registration/impl/gicp.hpp b/registration/include/pcl/registration/impl/gicp.hpp index 70e6c98d745..45f1ca76759 100644 --- a/registration/include/pcl/registration/impl/gicp.hpp +++ b/registration/include/pcl/registration/impl/gicp.hpp @@ -43,14 +43,6 @@ #include #include -/////////////////////////////////////////////////////////////////////////////////////////// -template void -pcl::GeneralizedIterativeClosestPoint::setInputCloud ( - const typename pcl::GeneralizedIterativeClosestPoint::PointCloudSourceConstPtr &cloud) -{ - setInputSource (cloud); -} - //////////////////////////////////////////////////////////////////////////////////////// template template void diff --git a/registration/include/pcl/registration/impl/registration.hpp b/registration/include/pcl/registration/impl/registration.hpp index bbee1733421..8df1672df5a 100644 --- a/registration/include/pcl/registration/impl/registration.hpp +++ b/registration/include/pcl/registration/impl/registration.hpp @@ -38,21 +38,6 @@ * */ -/////////////////////////////////////////////////////////////////////////////////////////// -template void -pcl::Registration::setInputCloud ( - const typename pcl::Registration::PointCloudSourceConstPtr &cloud) -{ - setInputSource (cloud); -} - -/////////////////////////////////////////////////////////////////////////////////////////// -template typename pcl::Registration::PointCloudSourceConstPtr const -pcl::Registration::getInputCloud () -{ - return (getInputSource ()); -} - /////////////////////////////////////////////////////////////////////////////////////////// template inline void pcl::Registration::setInputTarget (const PointCloudTargetConstPtr &cloud) diff --git a/registration/include/pcl/registration/registration.h b/registration/include/pcl/registration/registration.h index 41f62dfc34c..01b7af94b97 100644 --- a/registration/include/pcl/registration/registration.h +++ b/registration/include/pcl/registration/registration.h @@ -174,20 +174,6 @@ namespace pcl void setCorrespondenceEstimation (const CorrespondenceEstimationPtr &ce) { correspondence_estimation_ = ce; } - /** \brief Provide a pointer to the input source - * (e.g., the point cloud that we want to align to the target) - * - * \param[in] cloud the input point cloud source - */ - PCL_DEPRECATED ("[pcl::registration::Registration::setInputCloud] setInputCloud is deprecated. Please use setInputSource instead.") - void - setInputCloud (const PointCloudSourceConstPtr &cloud); - - /** \brief Get a pointer to the input point cloud dataset target. */ - PCL_DEPRECATED ("[pcl::registration::Registration::getInputCloud] getInputCloud is deprecated. Please use getInputSource instead.") - PointCloudSourceConstPtr const - getInputCloud (); - /** \brief Provide a pointer to the input source * (e.g., the point cloud that we want to align to the target) * diff --git a/test/registration/test_registration.cpp b/test/registration/test_registration.cpp index 33243148130..02d9e13605a 100644 --- a/test/registration/test_registration.cpp +++ b/test/registration/test_registration.cpp @@ -162,11 +162,6 @@ TEST (PCL, IterativeClosestPoint) { IterativeClosestPoint reg; PointCloud::ConstPtr source (cloud_source.makeShared ()); -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wdeprecated-declarations" - reg.setInputCloud (source); // test for PCL_DEPRECATED - source = reg.getInputCloud (); // test for PCL_DEPRECATED -#pragma GCC diagnostic pop reg.setInputSource (source); reg.setInputTarget (cloud_target.makeShared ()); reg.setMaximumIterations (50); diff --git a/test/registration/test_registration_api.cpp b/test/registration/test_registration_api.cpp index b10acd05b91..89624e8f0b2 100644 --- a/test/registration/test_registration_api.cpp +++ b/test/registration/test_registration_api.cpp @@ -131,11 +131,6 @@ TEST (PCL, CorrespondenceRejectorDistance) // re-do correspondence estimation boost::shared_ptr correspondences (new pcl::Correspondences); pcl::registration::CorrespondenceEstimation corr_est; -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wdeprecated-declarations" - corr_est.setInputCloud (source); // test for PCL_DEPRECATED - source = corr_est.getInputCloud (); // test for PCL_DEPRECATED -#pragma GCC diagnostic pop corr_est.setInputSource (source); corr_est.setInputTarget (target); corr_est.determineCorrespondences (*correspondences); @@ -237,11 +232,6 @@ TEST (PCL, CorrespondenceRejectorSampleConsensus) boost::shared_ptr correspondences_result_rej_sac (new pcl::Correspondences); pcl::registration::CorrespondenceRejectorSampleConsensus corr_rej_sac; -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wdeprecated-declarations" - corr_rej_sac.setInputCloud (source); // test for PCL_DEPRECATED - source = corr_rej_sac.getInputCloud (); // test for PCL_DEPRECATED -#pragma GCC diagnostic pop corr_rej_sac.setInputSource (source); corr_rej_sac.setInputTarget (target); corr_rej_sac.setInlierThreshold (rej_sac_max_dist);