-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Exclude doc files from CI to save CI time #4691
[CI] Exclude doc files from CI to save CI time #4691
Conversation
Fixed PointCloudLibrary#3999. Updates to doc, README, etc. don't run formatting + main CI.
This PR still runs the main CI for docs. Create a new issue for the docs or edit the existing issue to reflect the partially resolved state? |
yeah, current CI build is still based on the old azure pipelines file in master. It will take effect after merging this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't rescind my review from mobile, hence this. Please ignore
Adding the rationale in a second review below
fixed the name of the main build pipeline.
I've implemented the new pipeline in |
I think the latest commit looks good now. Could you take a look again please? |
I admit that the method is kind of obscure and tricky now. I'd add git check to make it more legible and comprehensible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@ueqri Could you do the following:
- Create a dummy project to show the CI runs (I believe you've already done this)
- Create a PR that runs only doc pipeline
- Create a PR that runs build then doc pipeline
Of course:satisfied:, I will do it in my repository and paste the result here soon. Thank you:satisfied:! |
Those md files are not part of the documentation, so no need for trigger.
I've made this in https://github.com/ueqri/pcl/tree/test-new-docs-pipeline, and related Azure pipelines dashboard are here: https://dev.azure.com/ueqri-ci/pcl-test/_build?view=runs As I didn't set branch rules for triggers, some push beyond The exactly related CI run are:
|
removed md files from PR trigger, and added conditions for `documentation` and `tutorials` stages to make sure they run as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sample links look good.
Just a few minor comments
I'm gratitude to you for helping me and guiding me in this PR. Thank you! 😀 And I was wondering if this could be merged, and then I could contribute to this issue #3947 based on the changes in current branch. It's truly a great pleasure:heart:! |
Note to maintainers: We'll need to update the list of required CI for merge |
|
I'm really sorry to bring this mistake in the last stage:cry:, and thanks for your hotfix. I promise I will check more carefully at any time especially in online code edits. I apologize for causing this trouble. |
Meh. Happens :) |
Added the exclude rules for push and PR triggers. So updates to doc, README, etc. won't cause the formatting + main CI to run.