Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Polymer.dom()._query #3214

Closed
nazar-pc opened this issue Dec 18, 2015 · 3 comments
Closed

Missing Polymer.dom()._query #3214

nazar-pc opened this issue Dec 18, 2015 · 3 comments

Comments

@nazar-pc
Copy link
Contributor

After commit 306cc81 from #3112 Shadow DOM support is broken.
Calling Polymer.updateStyles() results in:

TypeError: Polymer.dom(...)._query is not a function at HTMLElement.Polymer.Base._addFeature._updateRootStyles (...) at Function.Polymer.updateStyles (...) at HTMLDocument.ready_callback (...) at ...

Namely, Shadow DOM version of Polymer.dom(...) does not have _query() method used here:

var c$ = Polymer.dom(root)._query(function(e) {

This should be fixed before next release.
@sorvell @kevinpschaaf

@nazar-pc
Copy link
Contributor Author

Fixed in #3215

@devinivy
Copy link

Is there a simple test to be written to catch future regressions?

Edit
Ah, presumably this addition does the trick? https://github.com/Polymer/polymer/pull/3215/files#diff-0e5ec35aef25e29aa04d1f3c8e1b428eR65

@nazar-pc
Copy link
Contributor Author

Yes, you're pointing to right location. I decided to reuse existing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants