ShadyDOM: use a linked-list for tree accessors #3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 18, 2015 17:00
| */ | ||
| removeChild: function(node) { | ||
| if (dom(node).parentNode !== this.node) { | ||
| console.warn('The node to be removed is not a child of this node', |
There was a problem hiding this comment.
We throw above on L70, but just warn here?
added 11 commits
December 7, 2015 14:00
… since it is not universally supported.
…use TreeApi.Logical methods to get node leaves. Avoid making a Polymer.dom when TreeApi.Logical can provide the needed info.
…ng location if it's not a fragment and has a parent.
Conflicts: src/lib/dom-api.html src/mini/shady.html
…mports polyfill support.
…d patching via a linked list.
|
LGTM |
kevinpschaaf
added a commit
that referenced
this pull request
Dec 16, 2015
ShadyDOM: use a linked-list for tree accessors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2645.