Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap? #333

Open
tstirrat15 opened this issue Oct 23, 2019 · 1 comment
Open

Roadmap? #333

tstirrat15 opened this issue Oct 23, 2019 · 1 comment

Comments

@tstirrat15
Copy link

tstirrat15 commented Oct 23, 2019

First: This library is awesome. I haven't found anything that provides similar functionality, and when used as documented, it Just Works^tm.

However, there's things that could be modernized:

  1. HOC => renderProps and/or hook
  2. Move off of findDOMNode (deprecated in strictMode)

I saw the conversation in #295, and it makes it sound like it's less because of any particular technical reason, and more because of what React looked like when v1 of this lib was written.

Is there interest in a rewrite + major release? Do you have thoughts on what you'd like to see in that rewrite?

I'm happy to help make it happen - I just wanted to make sure that we've got a similar vision before I go start submitting PRs.

@Pomax
Copy link
Owner

Pomax commented Oct 24, 2019

I am 100% for a "from scatch" v7 based on what React looks like these days, I just haven't had any time to dedicate to this myself. If you want to start taking a stab at that, I'd be more than happy to review, though!

The important part is that "it works", really. React 16.8 does that a fair bit different from earlier versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants