Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequential GUIDs #260

Merged
merged 2 commits into from
Apr 29, 2017
Merged

Conversation

caleblloyd
Copy link
Contributor

@caleblloyd caleblloyd commented Apr 15, 2017

  • Adapt Sequential GUID generation to work on MySQL
  • Re-work of initial PR MySQL 顺序Guid算法更新 #258
  • Must take into consideration if GUIDs are stored as binary (OldGuids=true) or char(36) (OldGuids=false)

Still need to add tests before we can merge

@jp7677
Copy link

jp7677 commented Apr 16, 2017

Interesting.. What would I have to do to make advantage of this? We already use char(36) as column type for our GUIDs. Would this affect existing data?

Edit: I guess this is about https://docs.microsoft.com/en-us/ef/core/modeling/generated-properties?

@caleblloyd
Copy link
Contributor Author

This only affects GUIDs that are part of the primary key that have not been set. It will set them automatically, no data annotation needed.

This happens right now, except the generated GUID is optimized for SQL Server, and not MySQL.

@jp7677
Copy link

jp7677 commented Apr 16, 2017

Thanks for the info and nice improvement!

@caleblloyd
Copy link
Contributor Author

@kagamine tests are done for this, it's ready for review

@yukozh yukozh merged commit a2d658c into PomeloFoundation:master Apr 29, 2017
@jp7677
Copy link

jp7677 commented May 2, 2017

@kagamine, nice to see that this one has been merged. May I ask for a new nuget beta build, would love to play with it?

@yukozh
Copy link
Member

yukozh commented May 2, 2017

myget feed 1.1.2

@jp7677
Copy link

jp7677 commented May 3, 2017

Thanks, that will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants