Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ASIHPI host API #444

Closed
wants to merge 1 commit into from
Closed

remove ASIHPI host API #444

wants to merge 1 commit into from

Conversation

Be-ing
Copy link
Collaborator

@Be-ing Be-ing commented Jan 13, 2021

This was a host API for one specific vendor's audio interfaces. It
has been obsolete since the asihpi ALSA driver was merged into
Linux 2.6.35 in 2010.

philburk
philburk reviewed Jan 16, 2021
View reviewed changes
Copy link
Collaborator

@philburk philburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://audioscience.com/internet/download/sdk/sdk.htm
they recommend ALSA for Linux. So it does seem obsolete. But someone may be using it.

We should send a notice to the PortAudio mailing list that it is being deprecated.
Maybe that has already been done. If no one objects then I am OK with removing it.

@philburk
Copy link
Collaborator

I sent an email to PortAudio list asking if anyone objects.

@Be-ing
Copy link
Collaborator Author

Be-ing commented Jan 21, 2021

Considering the lack of objections, I think we should go ahead and merge this. But there's no rush to remove this. Let's wait until after a new release with #356.

@RossBencina RossBencina added the src-asihpi Audio Science ASIHPI Host API /src/hostapi/asihpi label Jan 27, 2021
@philburk philburk added this to the V19.8 milestone Apr 8, 2021
@Be-ing Be-ing requested a review from philburk April 25, 2021 20:38
@Be-ing
remove ASIHPI host API
82d9d5d 
This was a host API for one specific vendor's audio interfaces. It
has been obsolete since the asihpi ALSA driver was merged into
Linux 2.6.35 in 2010.
https://alsa-project.org/main/index.php/Matrix:Module-asihpi
RossBencina
RossBencina reviewed Apr 29, 2021
View reviewed changes
Copy link
Collaborator

@RossBencina RossBencina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no evidence that HPI is "obsolete". There are recent (2019) HPI drivers at the link below, and no indication that the HPI is deprecated on Linux.

https://audioscience.com/internet/download/sdk/sdk.htm

@philburk
Copy link
Collaborator

Upon reviewing the website again, it seems that Audio Science is supporting their proprietary API and that is is sometimes more up-to-date than the ALSA or other APIs.

We will close this for now until until the API is abandoned by Audio Science.

@philburk philburk closed this Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RossBencina RossBencina RossBencina approved these changes

@philburk philburk philburk approved these changes

Assignees

@RossBencina RossBencina

Labels
src-asihpi Audio Science ASIHPI Host API /src/hostapi/asihpi
Projects
None yet
Milestone
V19.8
Development

Successfully merging this pull request may close these issues.
3 participants
@Be-ing @philburk @RossBencina