Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rotate session id when reset is called #174

Merged
merged 10 commits into from
Aug 29, 2024
Merged

fix: rotate session id when reset is called #174

merged 10 commits into from
Aug 29, 2024

Conversation

marandaneto
Copy link
Member

💡 Motivation and Context

Similar to PostHog/posthog-android#168
on top of #171 to avoid merging conflicts (merge this one first)

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto marked this pull request as ready for review August 29, 2024 07:56
@marandaneto marandaneto requested a review from a team August 29, 2024 07:56
@marandaneto marandaneto changed the title chore: expose session id setter fix: rotate session id when reset is called Aug 29, 2024
Base automatically changed from chore/expose-session-setter to main August 29, 2024 09:28
@marandaneto marandaneto merged commit 9c6bacf into main Aug 29, 2024
6 checks passed
@marandaneto marandaneto deleted the fix/reset-sessionid-rotate branch August 29, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daibhin daibhin daibhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marandaneto @daibhin