Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils): crash when dealing with colors from storyboard #229

Merged
merged 4 commits into from
Nov 5, 2024
Merged

fix(utils): crash when dealing with colors from storyboard #229

merged 4 commits into from
Nov 5, 2024

Conversation

ioannisj
Copy link
Contributor

@ioannisj ioannisj commented Nov 4, 2024 •
edited
Loading

💡 Motivation and Context

see: #226

Dealing with some random crash when dealing with wireframe mode, storyboard files and dynamic catalog colors (UIDynamicCatalogColor)

Quick fix for now to try and avoid these crashes

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@ioannisj ioannisj requested a review from marandaneto as a code owner November 4, 2024 13:44
@ioannisj ioannisj requested a review from a team November 4, 2024 13:44
@ioannisj ioannisj merged commit f72202c into main Nov 5, 2024
7 checks passed
@ioannisj ioannisj deleted the fix/crash-in-toRGBString branch November 5, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ioannisj @marandaneto