Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recording: fix RN iOS masking #230

Merged
merged 6 commits into from
Nov 5, 2024
Merged

recording: fix RN iOS masking #230

merged 6 commits into from
Nov 5, 2024

Conversation

marandaneto
Copy link
Member

💡 Motivation and Context

Closes PostHog/posthog-js-lite#292

💚 How did you test it?

Running multiple tests with multiple views/accesibility labels etc

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto requested a review from a team November 5, 2024 10:53
@marandaneto marandaneto marked this pull request as ready for review November 5, 2024 10:54
@marandaneto marandaneto mentioned this pull request Nov 5, 2024
Closed
@marandaneto marandaneto merged commit 0d57ca3 into main Nov 5, 2024
6 checks passed
@marandaneto marandaneto deleted the fix/rn-ios-masking branch November 5, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioannisj ioannisj ioannisj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: React native session replay includes View and WebView when ph-no-capture is set
2 participants
@marandaneto @ioannisj