RN Session replay plugin isn't starting a new recording after app restart

[marandaneto]

Bug description

Context PostHog/posthog#13269 (comment)
This is by design but I understand why it isn't obvious.
On RN, the session only rotates if the app is inactive for more than 30 minutes, and the session ID survives app restart which is different than Android and iOS.
Changing this would break the behavior of people who rely on this for session durations.
So we have a few options here, change the behavior and break compatibility, add a flag to opt in to the new behavior, or else.

How to reproduce

Related sub-libraries

• All of them
• posthog-web
• posthog-node
• posthog-react-native

Additional context

Thank you for your bug report – we love squashing them!

[marandaneto]

cc @chasem-dev
https://github.com/PostHog/posthog-js-lite/releases/tag/posthog-react-native-v3.3.0

[chasem-dev]

@marandaneto I just tried this build since it contains both the Identity and sesion changes. When I'm compiling, I'm noticing a strange error preventing my app from bundling. Seems like it's more related to the identity ticket?

[RUN_FASTLANE] ▸ ** ARCHIVE FAILED **
[RUN_FASTLANE] ▸ The following build commands failed:
[RUN_FASTLANE] ▸        SwiftEmitModule normal arm64 Emitting\ module\ for\ posthog_react_native_session_replay (in target 'posthog-react-native-session-replay' from project 'Pods')
[RUN_FASTLANE] ▸ (1 failure)
[RUN_FASTLANE] ** ARCHIVE FAILED **
[RUN_FASTLANE] 
[RUN_FASTLANE] 
[RUN_FASTLANE] The following build commands failed:
[RUN_FASTLANE]  SwiftEmitModule normal arm64 Emitting\ module\ for\ posthog_react_native_session_replay (in target 'posthog-react-native-session-replay' from project 'Pods')
[RUN_FASTLANE] (1 failure)
[RUN_FASTLANE] Exit status: 65

[chasem-dev]

I found where it looks like you exposed the variable:
PostHog/posthog-ios@501cc8e

It seems like the version bump maybe wasn't picked up in a release?
PostHog/posthog-ios@333ca7f

Which library uses the posthog-ios dependency?

[marandaneto]

@chasem-dev have you upgraded your pods? Try to clean and install your pods, the session replay plugin uses the iOS SDK

[chasem-dev]

@marandaneto That worked! I ran cd ios and then did pod update. Testing things out now. Sorry for the false alarm! Thanks for the help