API: expose domains.account #2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| reset(); | ||
| } | ||
| catch (SSqlException &e) { | ||
| throw PDNSException("GSQLBackend unable to set kind of domain \""+domain+"\": "+e.txtReason()); |
There was a problem hiding this comment.
Please replace kind by account in this error
|
goracle not supported? =) |
|
Thank you. I will have to wait for merge + autotest packages for testing. |
ahupowerdns
added a commit
that referenced
this pull request
Feb 8, 2015
API: expose domains.account
|
Thanks to @zeha for adding this, thanks to @ahupowerdns for merging, thanks to @Habbie for not bawling out @ahupowerdns for merging ;-) it works. I tested both GET and POST requests. |
|
I hope not - the code duplication between |
|
No, I merely forgot that these are two separate code paths. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @jpmens in #2188