Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSReadLine doesn't work properly with Windows Terminal's background image #1842

Closed
lanyizi opened this issue Sep 30, 2020 · 4 comments
Closed

Comments

@lanyizi
Copy link

lanyizi commented Sep 30, 2020

Environment

PS version: 7.0.3
PSReadline version: 2.1.0-beta2
os: 10.0.18362.1074 (WinBuild.160101.0800)
PS file version: 7.0.3.0
HostName: ConsoleHost (Windows Terminal)
BufferWidth: 120
BufferHeight: 30

Steps to reproduce & Expected behavior & Actual behavior

(From PowerShell/PowerShell#13720)

I think the screenshot below should be self-explanatory, but let me explain more precisely.
Windows Terminal allows us to set a background image, then it will replace the area occupied by the original background color with the background image.
But when I'm typing commands that contain spaces, the background color of text returned to be the original background color, instead of being "transparent" (or more preciesly, instead of displaying the content of background image).
It only occurs when I'm typing commands, looks like this problem won't be triggered when I'm writing a string literal, even if it contains spaces, as shown in the screenshot.
image

If I unload PSReadLine module, the issue won't occur anymore.
image

@ghost ghost added the Needs-Triage 🔍 It's a new issue that core contributor team needs to triage. label Sep 30, 2020
@DHowett
Copy link
Contributor

DHowett commented Sep 30, 2020

this is a duplicate of #830, and only happens if you're using the "dotnet global" tool version of PowerShell and haven't updated PSReadline.

Here's a bit about it in the Terminal docs

@lanyizi
Copy link
Author

lanyizi commented Oct 1, 2020

@DHowett Yes, I have "dotnet global" tool version of PowerShell core, but I think my PSReadLine is already up-date?
My PSReadline version is 2.1.0-beta2, and I still have this issue..

@vexx32
Copy link

vexx32 commented Oct 1, 2020

Hmm, looking over the releases, it looks like that fix was made after the beta release and released as 2.0.3; I don't see another beta release after that, so it looks like it hasn't been rolled into a beta branch just yet.

@lanyizi
Copy link
Author

lanyizi commented Oct 1, 2020

@vexx32 looks like that's it, I uninstalled the pre-release version of PSReadLine and issue has been fixed.

@lanyizi lanyizi closed this as completed Oct 1, 2020
@ghost ghost removed the Needs-Triage 🔍 It's a new issue that core contributor team needs to triage. label Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants