Add UseUsingScopeModifierInNewRunspaces rule#1419

Merged

bergmeister merged 59 commits intoPowerShell:masterfrom Jawz84:1410_foreach_parallel_rule

Mar 24, 2020

+940-10

Commits on Feb 16, 2020

Add tests for AvoidUnInitializedVarsInNewRunspaces

Jos Koelewijn
authored and
Jos Koelewijn
committed
Add strings for AvoidUnInitializedVarsInNewRunspaces

Jos Koelewijn
authored and
Jos Koelewijn
committed

Commits on Feb 17, 2020

Add documentation

Jos Koelewijn
authored and
Jos Koelewijn
committed
wrestling with Ast in C# - not working

Jos Koelewijn
authored and
Jos Koelewijn
committed

Commits on Feb 20, 2020

Add sensible warning message

Jos Koelewijn
authored and
Jos Koelewijn
committed
remove unnecessary boilerplate from test

Jos Koelewijn
authored and
Jos Koelewijn
committed
clean up and finetune rule

Jos Koelewijn
authored and
Jos Koelewijn
committed
Add RuleToTest parameter to Test-ScriptAnalyzer to aid with test driven rule development

Jos Koelewijn
authored and
Jos Koelewijn
committed
increment rule count to fix test

Jos Koelewijn
authored and
Jos Koelewijn
committed
add reference to rule documentation

Jos Koelewijn
authored and
Jos Koelewijn
committed
exclude built-in variables

Jos Koelewijn
authored and
Jos Koelewijn
committed

Commits on Feb 24, 2020

change using directive => scoope modifier

Jos Koelewijn
authored and
Jos Koelewijn
committed
add tests for InlineScript, Invoke-Command and Start-(Thread)Job

Jos Koelewijn
authored and
Jos Koelewijn
committed
add rule implementation for InlineScript, Invoke-Command and Start-(Thread)Job

Jos Koelewijn
authored and
Jos Koelewijn
committed
Refactor and cleanup

Jos Koelewijn
authored and
Jos Koelewijn
committed
small cleanup

Jos Koelewijn
authored and
Jos Koelewijn
committed

Commits on Feb 27, 2020

explain all applicable situations in documentation

Jos Koelewijn
authored and
Jos Koelewijn
committed
simplify code for adding sessions to dict

Jos Koelewijn
authored and
Jos Koelewijn
committed
Revert "Add RuleToTest parameter to Test-ScriptAnalyzer to aid with test driven rule development"

Jos Koelewijn
authored and
Jos Koelewijn
committed
Rename rule to UseUsingScopeModifierInNewRunspaces

Jos Koelewijn
authored and
Jos Koelewijn
committed
refactor grouping of script blocks by session name

Jos Koelewijn
authored and
Jos Koelewijn
committed

Commits on Mar 4, 2020

Add suggested correction implementation

Jos Koelewijn
authored and
Jos Koelewijn
committed

Commits on Mar 7, 2020

Add test for suggested corrections, fix typos

Jos Koelewijn
authored and
Jos Koelewijn
committed
Refactor to AstVisitor/AstVisitor2 WIP

Jos Koelewijn
authored and
Jos Koelewijn
committed
Update Rules/UseUsingScopeModifierInNewRunspaces.cs

Jawz84
and
rjmholt
authored
Update Rules/UseUsingScopeModifierInNewRunspaces.cs

Jawz84
and
rjmholt
authored
Process review comments

Jos Koelewijn
authored and
Jos Koelewijn
committed
Merge remote-tracking branch 'refs/remotes/origin/1410_foreach_parallel_rule' into 1410_foreach_parallel_rule

Jos Koelewijn
authored and
Jos Koelewijn
committed

Commits on Mar 10, 2020

Add tests for command name and icm -session

Jos Koelewijn
authored and
Jos Koelewijn
committed
Add icm -session logic to visitor and tidy up

Jos Koelewijn
authored and
Jos Koelewijn
committed
fix build for windows powershell

Jos Koelewijn
authored and
Jos Koelewijn
committed

Commits on Mar 11, 2020

Revert "fix build for windows powershell"

Jos Koelewijn
authored and
Jos Koelewijn
committed
Change private class to internal class for Windows PowerShell

Jos Koelewijn
authored and
Jos Koelewijn
committed

Commits on Mar 12, 2020

Add logic to detect DSCScriptResource

Jos Koelewijn
authored and
Jos Koelewijn
committed
Add tests for DSC Script resource

Jos Koelewijn
authored and
Jos Koelewijn
committed

Commits on Mar 13, 2020

Enhance label test topic

Jawz84
and
rjmholt
authored
repair test indentation and add newline at eof

Jos Koelewijn
authored and
Jos Koelewijn
committed
Merge remote-tracking branch 'refs/remotes/origin/1410_foreach_parallel_rule' into 1410_foreach_parallel_rule

Jos Koelewijn
authored and
Jos Koelewijn
committed
Move testcases to BeforeAll blocks

Jos Koelewijn
authored and
Jos Koelewijn
committed
Add documentation that DSC Script resource is supported

Jos Koelewijn
authored and
Jos Koelewijn
committed
change string[] to IReadOnlyList<string>

Jawz84
and
rjmholt
authored
extract scriptBlockPosition as a variable for readability

Jawz84
and
rjmholt
authored
put arguments on their own line for readability

Jos Koelewijn
authored and
Jos Koelewijn
committed
make visitor class a private, nested class in rule

Jos Koelewijn
authored and
Jos Koelewijn
committed
change 'var' to type name for method calls

Jos Koelewijn
authored and
Jos Koelewijn
committed
fix indentation for nested visitor class

Jos Koelewijn
authored and
Jos Koelewijn
committed
Remove explicit 'ToList()' for performance

Jawz84
and
rjmholt
authored
add check for strongly typed assignments

Jos Koelewijn
authored and
Jos Koelewijn
committed
Merge remote-tracking branch 'refs/remotes/origin/1410_foreach_parallel_rule' into 1410_foreach_parallel_rule

Jos Koelewijn
authored and
Jos Koelewijn
committed
Add todo comments

Jos Koelewijn
authored and
Jos Koelewijn
committed
refactor FindAll predicates to static methods

Jos Koelewijn
authored and
Jos Koelewijn
committed

Commits on Mar 14, 2020

Refactor GetSessionName for performance.

Jos Koelewijn
authored and
Jos Koelewijn
committed

Commits on Mar 19, 2020

use full type for string expression variable

Jawz84
and
rjmholt
authored
use full type name for foreach variable initialization

Jawz84
and
rjmholt
authored
refactor diagnostic message out to local variable

Jawz84
and
rjmholt
authored
WIP: apply review suggestions

Jos Koelewijn
authored and
Jos Koelewijn
committed

Commits on Mar 20, 2020

apply review suggestions

Jos Koelewijn
authored and
Jos Koelewijn
committed
Merge remote-tracking branch 'refs/remotes/origin/1410_foreach_parallel_rule' into 1410_foreach_parallel_rule

Jos Koelewijn
authored and
Jos Koelewijn
committed
Fix CR/LF -> LF

Jos Koelewijn
authored and
Jos Koelewijn
committed