Skip to content
This repository has been archived by the owner on Apr 24, 2020. It is now read-only.

Updated few icons to use with git. #91

Merged
merged 2 commits into from
Sep 15, 2015

Conversation

tusharsrivastava
Copy link

I have updated some icons' utf8 code to look better. Old icons were not matched to many icons.

@dritter
Copy link
Member

dritter commented Sep 12, 2015

Thanks for your contribution.

Do you use the "fallback-strategy" of awesome-terminal-fonts?
Unfortunately this produces different unicode-codepoints than the "patching-strategy" which this theme is using.. I'll try to suggest a pull request to awesome-terminal-fonts in the next days..

@bhilburn
Copy link
Member

@tusharsrivastava - Thanks so much for getting involved and submitting a contribution!

@dritter - Are you saying that this PR needs an update to work in a fallback situation?

@dritter
Copy link
Member

dritter commented Sep 14, 2015

@bhilburn No, I think this PR is meant for the fallback strategy.

Maybe we should have a new section in the icons-variable to support fallback strategy (awesome-fallback). IMHO this should be master...tcbbd:master as @tcbbd made a quite complete port.

bhilburn added a commit that referenced this pull request Sep 15, 2015
Updated some of the Awesome Powerline Icons.
@bhilburn bhilburn merged commit 2a2dfdf into Powerlevel9k:master Sep 15, 2015
bhilburn pushed a commit that referenced this pull request Sep 15, 2015
Fixed conflict caused by PR #91.
@dritter
Copy link
Member

dritter commented Sep 17, 2015

@bhilburn Uhm. Merging this means, that we now have glyphs for fallback- and patching-strategy all together. So Icons are now broken in awesome-patched-mode..

It would be better to revert this merge and make a new branch in the icons-definition (see my previous comment).

@bhilburn
Copy link
Member

@dritter - Hm, I'm really having trouble understanding how you would like to handle this, as our icon expert =)

Can you lay out a step-by-step plan for what needs to happen? I'll revert this merge in master and next right away, though.

Edit: I believe both master and next are now fixed. Can you confirm, @dritter, and if not, can you submit a PR to fix?

bhilburn pushed a commit that referenced this pull request Sep 17, 2015
This reverts commit 2a2dfdf, reversing
changes made to 1390fbd.
bhilburn pushed a commit that referenced this pull request Sep 17, 2015
@dritter dritter mentioned this pull request Sep 18, 2015
@dritter
Copy link
Member

dritter commented Sep 19, 2015

@bhilburn yes. Now it looks good again on master and next.

@bhilburn
Copy link
Member

@dritter - Great! Thanks for confirming!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants