Remove -> None annotation from __init__ #472
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last month, mypy adopted a change that makes the
-> None
return annotation for otherwise-annotated__init__()
signatures unnecessary.This PR implements that change in our codebase, since I think it's much cleaner (
__init__
is ALWAYS-> None
).However, this is a stylistic question so I put it up for debate.
Here's the documentation:
https://mypy.readthedocs.io/en/latest/class_basics.html#annotating-init-methods
And here's the 4 years of discussion:
python/mypy#604