Update critical_service_loop to throw a runtime error on failure
#9267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug where the agent hangs when only one of its critical service loops fails
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
zanieb
commented
Apr 20, 2023
Comment on lines
-67
to
-68
| except KeyboardInterrupt: | ||
| return |
There was a problem hiding this comment.
We should never swallow keyboard interrupts
4 tasks
|
This should also resolve #9052 |
|
@desertaxle thank you that's the one I was looking for! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where the agent hangs when only one of its critical service loops fails.
We've been observing this for a while, but it was not clear what the cause was. It turns out we just returned from this function on error because we assumed it was being used in a context where that would result in an exit. Since the agent now checks for cancelled runs in addition to scheduled runs in separate loops, if one loop failed the agent could continue running without reporting the failure. This almost definitely patches the same bug for workers.
Loosely related to some behavior in #7442 e.g. #7442 (comment)
cc @jawnsy who first reported this behavior
Closes #9052