[NEW UI] finish front version choice #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M0rgan01
reviewed
Oct 14, 2024
M0rgan01
reviewed
Oct 14, 2024
controllers/admin/self-managed/UpdatePageVersionChoiceController.php
Outdated
Show resolved
Hide resolved
ga-devfront
force-pushed
the
feat/continue-version-choice
branch
from
53d9ce8
to
52c23bd
Compare
ga-devfront
force-pushed
the
feat/continue-version-choice
branch
2 times, most recently
from
2c02e13
to
c92c655
Compare
M0rgan01
reviewed
Oct 18, 2024
M0rgan01
force-pushed
the
feat/continue-version-choice
branch
6 times, most recently
from
1c9f19b
to
3fc280c
Compare
M0rgan01
force-pushed
the
feat/continue-version-choice
branch
from
f77483b
to
6731c7b
Compare
ga-devfront
force-pushed
the
feat/continue-version-choice
branch
from
6731c7b
to
5e73116
Compare
Quetzacoalt91
force-pushed
the
feat/continue-version-choice
branch
7 times, most recently
from
19b3930
to
32c0971
Compare
ga-devfront
force-pushed
the
feat/continue-version-choice
branch
from
bf36808
to
349e60c
Compare
Quetzacoalt91
previously approved these changes
Oct 24, 2024
ga-devfront
dismissed stale reviews from Quetzacoalt91 and M0rgan01
via
ee87a87
Quetzacoalt91
previously approved these changes
Oct 25, 2024
|
AureRita
previously approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Hi @ga-devfront
Thank you for your PR, I tested it and it seems to works as you can see :
recording.312.webm
Tested from :
1.7.8.9 to 8.2
8.0.5 to 8.1.5
8.1.5 to 8.2
8.1.5 to 9.0.0
8.0.5 to 9.0.0
We can se that if we don't have matched two zip and xml we'll have the same behavior that previously. We already see that together and 'll fix it on another PR
Because the PR seems to works as expected, It's QA ✔️
Thank you
ga-devfront
dismissed stale reviews from AureRita and Quetzacoalt91
via
1994777
Quetzacoalt91
approved these changes
Oct 25, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
&new-ui=1&page=update-page-version-choice