Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update order-confirmation-table.tpl - add missing classes #158

Open
wants to merge 1 commit into
base: 2.1.x
Choose a base branch
from

Conversation

ShaiMagal
Copy link

@ShaiMagal ShaiMagal commented Nov 7, 2024

Questions Answers
Description? Add missing classes for CSS/JS targeting. Partially related to issue #37333. If this PR will be accepted, I will do same for hummingbird.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #37333
Sponsor company https://www.openservis.cz/
How to test?

@Hlavtox
Copy link
Contributor

Hlavtox commented Nov 11, 2024

@kpodemski We didn't find any better solution for this usecase. So we decided to at least add classes like in the top cart summary here, so we can change it by JS.

Do you have any better names for the classes or it's ok?

@ShaiMagal ShaiMagal changed the base branch from develop to 2.1.x November 11, 2024 14:10
@ShaiMagal
Copy link
Author

@kpodemski adding classes at least is small thing and every theme should have classes for CSS targeting, so I think, this PR isn't problem .)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for review
Development

Successfully merging this pull request may close these issues.

2 participants