-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change folder name for contactform.tpl #81
Conversation
Hello @Touxten! This is your first pull request on contactform repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
Hello @Touxten Since it hasn’t worked, I think it is not a BC Break. I'll ping @Hlavtox for a second opinion. If that would’ve been a BC break, then the process is as follows:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a BC break, it never worked, so people may never use it. :-)
@Touxten Can you bump the version in php and xml file to 4.4.3? |
Done @kpodemski && @Hlavtox |
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
You did it, 😎 ( #60 (comment)) |
For BC break i am not sur because the file is not used ?