Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change folder name for contactform.tpl #81

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

Touxten
Copy link
Contributor

@Touxten Touxten commented Nov 23, 2024

Questions Answers
Description? In the contactform module is a path to contactform.tpl defined in incorrect way.
Type? bug fix
BC breaks? yes
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#35746
How to test? See issue
Sponsor company @friends-of-presta

For BC break i am not sur because the file is not used ?

@ps-jarvis
Copy link

Hello @Touxten!

This is your first pull request on contactform repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

@kpodemski
Copy link
Contributor

Hello @Touxten

Since it hasn’t worked, I think it is not a BC Break. I'll ping @Hlavtox for a second opinion.

If that would’ve been a BC break, then the process is as follows:

  • you make a change
  • you describe why it is required to introduce a new major version (e.g., there are backward incompatible changes inside)
  • you ping committers to create a new milestone for the new major version (if it doesn’t exist already)
  • It should then force us to release it as a major version.

kpodemski
kpodemski previously approved these changes Nov 26, 2024
Hlavtox
Hlavtox previously approved these changes Nov 26, 2024
Copy link
Contributor

@Hlavtox Hlavtox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a BC break, it never worked, so people may never use it. :-)

@Hlavtox
Copy link
Contributor

Hlavtox commented Nov 26, 2024

@Touxten Can you bump the version in php and xml file to 4.4.3?

@Touxten Touxten dismissed stale reviews from Hlavtox and kpodemski via 46ca855 November 26, 2024 10:14
@Touxten
Copy link
Contributor Author

Touxten commented Nov 26, 2024

Done @kpodemski && @Hlavtox

@Hlavtox Hlavtox merged commit 3e2f36f into PrestaShop:dev Nov 26, 2024
12 checks passed
@ps-jarvis
Copy link

PR merged, well done!

Message to @PrestaShop/committers: do not forget to milestone it before the merge.

@Hlavtox Hlavtox added this to the 4.4.3 milestone Nov 26, 2024
@PrestaEdit
Copy link

You did it, 😎 ( #60 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

contactform module - Incorrect path to TPL file
5 participants