From a951a8d9859ac78f2b993d72cf8c670dd51af6f7 Mon Sep 17 00:00:00 2001 From: Steffen Persch Date: Wed, 11 May 2016 00:10:58 +0200 Subject: [PATCH 1/4] remove string from parameter class --- src/PrintNode/Request.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PrintNode/Request.php b/src/PrintNode/Request.php index 5727991..6f772b9 100755 --- a/src/PrintNode/Request.php +++ b/src/PrintNode/Request.php @@ -489,7 +489,7 @@ public function getPrintJobsByPrinters() * @param string $computerId id of computer to find scales * @return Entity[] * */ - public function getScales(string $computerId) + public function getScales($computerId) { $endPointUrl = $this->apiurl."/computer/"; $endPointUrl.= $computerId; From 9493f4f0a6b24e9b0e237f34660db2ff11bfca3e Mon Sep 17 00:00:00 2001 From: Steffen Persch Date: Wed, 11 May 2016 00:11:13 +0200 Subject: [PATCH 2/4] fix typo --- src/PrintNode/Scale.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PrintNode/Scale.php b/src/PrintNode/Scale.php index 3b60eb3..6fee6e1 100755 --- a/src/PrintNode/Scale.php +++ b/src/PrintNode/Scale.php @@ -29,7 +29,7 @@ class Scale extends Entity protected $port; protected $count; protected $measurement; - protected $clientReprotedCreateTimestamp; + protected $clientReportedCreateTimestamp; protected $ntpOffset; protected $ageOfData; protected $computerId; From e0efed36491a99eb3119245791ffe87dd86b2e02 Mon Sep 17 00:00:00 2001 From: Steffen Persch Date: Wed, 11 May 2016 00:11:25 +0200 Subject: [PATCH 3/4] proper DateTime reference --- src/PrintNode/Scale.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PrintNode/Scale.php b/src/PrintNode/Scale.php index 6fee6e1..4f6af81 100755 --- a/src/PrintNode/Scale.php +++ b/src/PrintNode/Scale.php @@ -13,7 +13,7 @@ * @property-read string $port * @property-read int $count * @property-read int[string] $measurement - * @property-read DateTime $clientReportedCreateTimestamp + * @property-read \DateTime $clientReportedCreateTimestamp * @property-read string $ntpOffset * @property-read int $ageOfData * @property-read int $computerId From a245277d8bda6a6494b304f47e92ae31179a4a8a Mon Sep 17 00:00:00 2001 From: Steffen Persch Date: Mon, 16 May 2016 06:24:11 +0200 Subject: [PATCH 4/4] [REF] InvalidArgumentException namespace --- src/PrintNode/Request.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/PrintNode/Request.php b/src/PrintNode/Request.php index 6f772b9..62cb9f3 100755 --- a/src/PrintNode/Request.php +++ b/src/PrintNode/Request.php @@ -522,7 +522,7 @@ public function getPrintersByComputers() $arguments = func_get_args(); if (count($arguments) > 2) { - throw new InvalidArgumentException( + throw new \InvalidArgumentException( sprintf( 'Too many arguments given to getPrintersByComputers.' ) @@ -570,7 +570,7 @@ public function __call($methodName, $arguments) $arguments = array_shift($arguments); if (!is_string($arguments)) { - throw new InvalidArgumentException( + throw new \InvalidArgumentException( sprintf( 'Invalid argument type passed to %s. Expecting a string got %s', $methodName, @@ -614,7 +614,7 @@ public function __call($methodName, $arguments) public function patch(Entity $entity) { if (!($entity instanceof Entity)) { - throw new InvalidArgumentException( + throw new \InvalidArgumentException( sprintf( 'Invalid argument type passed to patch. Expecting Entity got %s', gettype($entity) @@ -644,7 +644,7 @@ public function patch(Entity $entity) public function post(Entity $entity) { if (!($entity instanceof Entity)) { - throw new InvalidArgumentException( + throw new \InvalidArgumentException( sprintf( 'Invalid argument type passed to patch. Expecting Entity got %s', gettype($entity) @@ -677,7 +677,7 @@ public function put() $entity = array_shift($arguments); if (!($entity instanceof Entity)) { - throw new InvalidArgumentException( + throw new \InvalidArgumentException( sprintf( 'Invalid argument type passed to patch. Expecting Entity got %s', gettype($entity)