From 728e9d734eff7a7af897a8760b081c479654336a Mon Sep 17 00:00:00 2001 From: Michael Schmidt Date: Sun, 9 Sep 2018 12:12:21 +0200 Subject: [PATCH 1/4] Updated README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 21c3b45ebe..c12e77dcf9 100644 --- a/README.md +++ b/README.md @@ -17,7 +17,7 @@ Prism depends on community contributions to expand and cover a wider array of us - Please try to err towards more smaller PRs rather than few huge PRs. If a PR includes changes I want to merge and changes I don't, handling it becomes difficult. - My time is very limited these days, so it might take a long time to review longer PRs (short ones are usually merged very quickly), especially those modifying the Prism Core. This doesn't mean your PR is rejected. - If you contribute a new language definition, you will be responsible for handling bug reports about that language definition. -- If you add a new language definition, theme or plugin, you need to add it to `components.js` as well, so that it becomes available to the download build page. +- If you add a new language definition, theme or plugin, you need to add it to `components.json` as well, so that it becomes available to the download build page. Thank you so much for contributing!! From 5c38ef7c55e9fed6b01a51495a12b1ad3fce14e5 Mon Sep 17 00:00:00 2001 From: Michael Schmidt Date: Sun, 9 Sep 2018 12:18:30 +0200 Subject: [PATCH 2/4] Mentioned the required rebuild --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index c12e77dcf9..92735d4fb0 100644 --- a/README.md +++ b/README.md @@ -17,7 +17,7 @@ Prism depends on community contributions to expand and cover a wider array of us - Please try to err towards more smaller PRs rather than few huge PRs. If a PR includes changes I want to merge and changes I don't, handling it becomes difficult. - My time is very limited these days, so it might take a long time to review longer PRs (short ones are usually merged very quickly), especially those modifying the Prism Core. This doesn't mean your PR is rejected. - If you contribute a new language definition, you will be responsible for handling bug reports about that language definition. -- If you add a new language definition, theme or plugin, you need to add it to `components.json` as well, so that it becomes available to the download build page. +- If you add a new language definition, theme or plugin, you need to add it to `components.json` as well and rebuild Prism using gulp, so that it becomes available to the download build page. Thank you so much for contributing!! From a0b1c70ed38016dcb42ed5db2fbb0abb1aae2323 Mon Sep 17 00:00:00 2001 From: RunDevelopment Date: Sun, 9 Sep 2018 18:42:45 +0200 Subject: [PATCH 3/4] Small edit --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 92735d4fb0..cd8c0b211e 100644 --- a/README.md +++ b/README.md @@ -17,7 +17,7 @@ Prism depends on community contributions to expand and cover a wider array of us - Please try to err towards more smaller PRs rather than few huge PRs. If a PR includes changes I want to merge and changes I don't, handling it becomes difficult. - My time is very limited these days, so it might take a long time to review longer PRs (short ones are usually merged very quickly), especially those modifying the Prism Core. This doesn't mean your PR is rejected. - If you contribute a new language definition, you will be responsible for handling bug reports about that language definition. -- If you add a new language definition, theme or plugin, you need to add it to `components.json` as well and rebuild Prism using gulp, so that it becomes available to the download build page. +- If you add a new language definition, theme or plugin, you need to add it to `components.json` as well and rebuild Prism running gulp, so that it becomes available to the download build page. Thank you so much for contributing!! From d4e82de4d40c8ca9d63571f0cdc29382e080f86f Mon Sep 17 00:00:00 2001 From: RunDevelopment Date: Mon, 10 Sep 2018 22:57:11 +0200 Subject: [PATCH 4/4] Fixed edit --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index cd8c0b211e..5d594f0889 100644 --- a/README.md +++ b/README.md @@ -17,7 +17,7 @@ Prism depends on community contributions to expand and cover a wider array of us - Please try to err towards more smaller PRs rather than few huge PRs. If a PR includes changes I want to merge and changes I don't, handling it becomes difficult. - My time is very limited these days, so it might take a long time to review longer PRs (short ones are usually merged very quickly), especially those modifying the Prism Core. This doesn't mean your PR is rejected. - If you contribute a new language definition, you will be responsible for handling bug reports about that language definition. -- If you add a new language definition, theme or plugin, you need to add it to `components.json` as well and rebuild Prism running gulp, so that it becomes available to the download build page. +- If you add a new language definition, theme or plugin, you need to add it to `components.json` as well and rebuild Prism by running `gulp`, so that it becomes available to the download build page. Thank you so much for contributing!!