Dynamically update a loot filter #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class adds filters to a Neversink loot filter file.
The Grpc and Grpc.Tools packages provide the ability for Visual Studio to automatically compile specified .proto files into C# classes, and the resulting classes are understood by Visual Studio.
This probably won't be necessary after we can update the config from the UI, but it is a good guide for while it must be updated manually.
aydjay
approved these changes
Jun 22, 2019
|
Thanks for spending time on this, I'm curious what's the reason behind adding protobuf, I assume the main driver is the autogeneration and error checking? |
|
Protobufs provide a strongly-typed and easy to understand data structure for storing user data, which can also be written to/read from JSON, with, indeed, automatic parsing and error checking. The generated classes provide typical functions for handling the data. (Personally, I would strongly prefer to use Proto2 syntax instead of Proto3, but that is not supported by the official protobuf C# library, though it is, in my opinion, superior in several aspects.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds limited support for updating loot filters after recreating the list of recipes. There are two types of loot filters that can be added: items that are missing for partially-completed same-base-type recipes (that is, having a Normal, Magic, and Rare item of the same base type), with a variant for near-20% quality bases; and items that are chancing bases for builds in the current league.
The configuration for updating the item filters is managed by a Protocol Buffer
.protofile. Support has been added for Visual Studio to automatically compile the.protofile into C# classes that are virtually immediately recognized by Visual Studio's error-checking- and intelligence-generating systems. Procurement reads and writes the actual configuration from and to a json file.Closes #821.