Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super maraton #1482

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Super maraton #1482

merged 6 commits into from
Oct 20, 2023

Conversation

danielferro69
Copy link
Contributor

@danielferro69 danielferro69 commented Oct 7, 2023

Resolves #1359

supermaraton.mp4

PBE Program-AR/pilas-bloques-exercises#53

@danielferro69 danielferro69 requested a review from a team as a code owner October 7, 2023 21:56
@asanzo
Copy link
Contributor

asanzo commented Oct 17, 2023

Guarda con los íconos de los bloques

@asanzo asanzo requested a review from dlopezalvas October 17, 2023 19:00
Copy link
Contributor

@dlopezalvas dlopezalvas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯


const nombre = 'LaSupermaraton';

moduloActividad(nombre, () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Estaría bueno tener un test para el caso que falle (cuando corre de más)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hecho !

@danielferro69
Copy link
Contributor Author

Guarda con los íconos de los bloques

@asanzo los iconos estan ok. Quiza en el video no se llegan a apreciar.

image

package.json Outdated Show resolved Hide resolved
@danielferro69 danielferro69 merged commit 2b95ca5 into develop Oct 20, 2023
8 checks passed
@danielferro69 danielferro69 deleted the superMaraton branch October 20, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Challenges: La maratón
3 participants