Reciclando papeles #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto reciclandoPapeles
dlopezalvas
approved these changes
Oct 27, 2023
src/escenas/ReciclandoPapeles.ts
Outdated
Comment on lines
65
to
69
| cantidadDePapelesSinLevantar(): number { | ||
| var cant: number = 0; | ||
| this.papeles.forEach( papel => cant += papel.subactores[0].vivo ); | ||
| return cant; | ||
| } |
There was a problem hiding this comment.
¿Se usa la cantidad para algo más que si está resuelto el problema?
Suggested change
| cantidadDePapelesSinLevantar(): number { | |
| var cant: number = 0; | |
| this.papeles.forEach( papel => cant += papel.subactores[0].vivo ); | |
| return cant; | |
| } | |
| hayPapelesSinLevantar(): boolean { | |
| return this.papeles.every( papel => papel.subactores[0].vivo ); | |
| } |
Si es solo para verificar si hay papeles quizás queda mas expresivo así
There was a problem hiding this comment.
Por un "problema en la logica" donde puedo levantar un papel y poner ese MISMO papel, sin soltarlo en todos los tachos, es que corroboro que sea la cantidad de filas. Por eso hice la cuenta. Es mas que nada para manejar el error.
No... estoy mal yo... Eso es con los tachos, no con los papeles. Esta perfecto lo que sugeris. Ya lo uso asi. Gracias
There was a problem hiding this comment.
de todas formas, me bajo tu reforma y la pruebo en los tests y en el ejemplo. Gracias
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Program-AR/pilas-bloques-ember#1364