Updated Danish translations #286

cmahopper · 2019-08-23T07:56:38Z

Updated Danish translations and fixed some abbreviations.

yuryleb

Thanks for fix but it will be good to update ChangeLog also 😉

yuryleb · 2019-08-23T16:45:44Z

And translations should be updated on https://www.transifex.com/project-osrm/osrm-text-instructions/language/da/ first not directly in languages/translations/da.json file

cmahopper · 2019-08-26T07:49:51Z

@yuryleb I see. The problem with translating on Transifex is that I cannot add modifiers as separate strings. See this for example:
https://github.com/Project-OSRM/osrm-text-instructions/pull/286/files#diff-2c8beca969ab6776d6f6d01bc61ea58aR208-R211

I cannot use the default modifier. It may work in English, but it doesn't work in Danish. The same goes for sharp/slight left/right. It's just not possible in Danish.

What would you suggest instead?

cmahopper · 2019-08-26T08:05:14Z

@yuryleb I've updated the Transifex translations to the best of my ability, but the issues above are still present.

yuryleb · 2019-08-26T13:57:14Z

Thank you. Could you please now update files again but from Transifex (and don't forget ChangeLog 😉) and point me some fixture files with these incorrect sharp/slight left/right strings and comment what should be there instead - this allows me to understand the issue more completely. IMHO this could be fixed with post-processing by new grammar rules for Danish but I need more info yet.

cmahopper

@yuryleb I've added a Changelog entry!

I've also added a comment for each of the tests where they are currently incorrect. Note that some strings were actually correct before my changes, but I fixed other incorrect strings instead. So it's impossible to fix everything with the current system.

Could you elaborate on what post-processing is in this case? Is it something I can help with?

test/fixtures/v5/end_of_road/sharp_left_destination.json

test/fixtures/v5/end_of_road/sharp_left_exit_destination.json

test/fixtures/v5/end_of_road/sharp_right_destination.json

test/fixtures/v5/end_of_road/sharp_right_exit_destination.json

test/fixtures/v5/end_of_road/slight_left_destination.json

test/fixtures/v5/turn/uturn_default.json

test/fixtures/v5/turn/uturn_destination.json

test/fixtures/v5/turn/uturn_exit.json

test/fixtures/v5/turn/uturn_exit_destination.json

test/fixtures/v5/turn/uturn_name.json

yuryleb · 2019-08-27T08:36:05Z

So let's try to reduce total number of incorrect phrases in fixures with Transifex first:

Move til inside modifier values
Update left/right words in sharp/slight modifiers
Use most common phrases beginnings (will solve different beginnings for straight/u-turn after)

cmahopper · 2019-08-27T08:42:57Z

@yuryleb I've updated Transifex and pushed the changes, I'm gonna go through the tests now and note any incorrect translations.

cmahopper

@yuryleb Done! Way fewer errors now :)

cmahopper · 2019-08-27T08:46:35Z

test/fixtures/v5/fork/straight_default.json

    "instructions": {
        "ar": " توجّه مباشرة",
-        "da": "Hold til ligeud ved udfletningen",
+        "da": "Hold ligeud ved udfletningen",


This should be "Fortsæt ligeud ved udfletningen"

cmahopper · 2019-08-27T08:46:48Z

test/fixtures/v5/fork/straight_destination.json

    "instructions": {
        "ar": "توجّه نحو مباشرة لمسافة {distance} ",
-        "da": "Hold mod ligeud mod Destination 1",
+        "da": "Hold ligeud mod Destination 1",


This should be "Fortsæt ligeud mod Destination 1"

cmahopper · 2019-08-27T08:47:16Z

test/fixtures/v5/fork/straight_exit.json

    "instructions": {
        "ar": "الزم مباشرة على Way Name",
-        "da": "Hold mod ligeud på Way Name",
+        "da": "Hold ligeud på Way Name",


This should be "Fortsæt ligeud på Way Name"

cmahopper · 2019-08-27T08:47:23Z

test/fixtures/v5/fork/straight_exit_destination.json

    "instructions": {
        "ar": "توجّه نحو مباشرة لمسافة {distance} ",
-        "da": "Hold mod ligeud mod Destination 1",
+        "da": "Hold ligeud mod Destination 1",


This should be "Fortsæt ligeud mod Destination 1"

cmahopper · 2019-08-27T08:47:33Z

test/fixtures/v5/fork/straight_name.json

    "instructions": {
        "ar": "الزم مباشرة على Way Name",
-        "da": "Hold mod ligeud på Way Name",
+        "da": "Hold ligeud på Way Name",


This should be "Fortsæt ligeud på Way Name"

cmahopper · 2019-08-27T08:54:01Z

test/fixtures/v5/turn/uturn_default.json

    "instructions": {
        "ar": "انعطف نحو الدوران للخلف",
-        "da": "Foretag et U-vending",
+        "da": "Drej U-vending",


This should be "Foretag en U-vending"

cmahopper · 2019-08-27T08:54:08Z

test/fixtures/v5/turn/uturn_destination.json

    "instructions": {
        "ar": "انعطف الدوران للخلف نحو Destination 1",
-        "da": "Foretag et U-vending mod Destination 1",
+        "da": "Drej U-vending mod Destination 1",


This should be "Foretag en U-vending mod Destination 1"

cmahopper · 2019-08-27T08:54:16Z

test/fixtures/v5/turn/uturn_exit.json

    "instructions": {
        "ar": "انعطف الدوران للخلف على Way Name",
-        "da": "Foretag et U-vending ad Way Name",
+        "da": "Drej U-vending ad Way Name",


This should be "Foretag en U-vending ad Way Name"

cmahopper · 2019-08-27T08:54:26Z

test/fixtures/v5/turn/uturn_exit_destination.json

    "instructions": {
        "ar": "انعطف الدوران للخلف نحو Destination 1",
-        "da": "Foretag et U-vending mod Destination 1",
+        "da": "Drej U-vending mod Destination 1",


This should be "Foretag en U-vending mod Destination 1"

cmahopper · 2019-08-27T08:54:34Z

test/fixtures/v5/turn/uturn_name.json

    "instructions": {
        "ar": "انعطف الدوران للخلف على Way Name",
-        "da": "Foretag et U-vending ad Way Name",
+        "da": "Drej U-vending ad Way Name",


This should be "Foretag en U-vending ad Way Name"

yuryleb

Thanks! So just 15 mistakes and just 2 replacements are necessary 👍

@1ec5, I recommend to merge this PR but don't close #258 - then I could propose another PR with initial grammar rules for Danish to fix rest issues.

yuryleb · 2019-08-29T08:12:30Z

@cmahopper, actually I already prepared a commit to push initial grammar rules right into your branch here but has no permissions to do this 😞 Maybe you could try to give me write access while we're waiting @1ec5 for approval?

cmahopper · 2019-08-29T08:23:56Z

@yuryleb You should be added as a collaborator now :)

yuryleb · 2019-08-29T08:40:31Z

Thanks! Please review proposed grammar rules and resulting fixtures. I didn't add special grammar tests so as all results are controlled with them.

cmahopper · 2019-08-29T08:44:10Z

@yuryleb The test results look perfect!

There's a final thing that still results in a weird speak, but I'm not sure if it can be fixed in the same way. I wrote it in this comment: #286 (comment)

The arrival string that starts with "Du vil ..." should be the only case where the first two words need to be switched. Would you be able to take a look at it?

yuryleb · 2019-08-29T08:49:45Z

Currently I has no idea how to fix this - current grammar rules implementation may not help in this case 😞 IMHO it's better to create separate issue specially for this to keep it in backlog at least.

@1ec5, we're ready to merge and to close #258 😉

cmahopper · 2019-08-29T08:50:12Z

@yuryleb Alright, thanks for the help anyway :)

1ec5

Thanks for your attention to detail! I wasn’t able to follow all the comments, but the changes look reasonable.

- Added a Yoruba localization. [#284](#284) - Renamed “traffic circle” to “roundabout” in the English localization. [#285](#285) - Rewrote the Burmese localization. [#282](#282) - Fixed typographical errors in Italian. [#281](#281) - Fixed grammatical errors in Danish. [#286](#286)

yuryleb reviewed Aug 23, 2019

View reviewed changes

cmahopper added 2 commits August 27, 2019 07:53

Updated Danish translations

f8d5fd9

Added changelog entry

c1b2bef

cmahopper commented Aug 27, 2019

View reviewed changes

Moved 'til' into modifiers to reduce amount of errors in Danish

84df4a9

Small fix for 'Go straight'

400ae60

cmahopper commented Aug 27, 2019

View reviewed changes

yuryleb approved these changes Aug 27, 2019

View reviewed changes

Initial grammar rules to fix straight and u-turn modifiers

80df3cc

1ec5 approved these changes Sep 3, 2019

View reviewed changes

1ec5 merged commit b185d23 into Project-OSRM:master Sep 3, 2019

danpaz mentioned this pull request Sep 16, 2019

Release v0.13.4 #287

Merged

Updated Danish translations #286

Updated Danish translations #286

Uh oh!

Conversation

cmahopper commented Aug 23, 2019

Uh oh!

yuryleb left a comment

Choose a reason for hiding this comment

Uh oh!

yuryleb commented Aug 23, 2019

Uh oh!

cmahopper commented Aug 26, 2019

Uh oh!

cmahopper commented Aug 26, 2019

Uh oh!

yuryleb commented Aug 26, 2019

Uh oh!

cmahopper left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yuryleb commented Aug 27, 2019

Uh oh!

cmahopper commented Aug 27, 2019

Uh oh!

cmahopper left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yuryleb left a comment

Choose a reason for hiding this comment

Uh oh!

yuryleb commented Aug 29, 2019

Uh oh!

cmahopper commented Aug 29, 2019

Uh oh!

yuryleb commented Aug 29, 2019

Uh oh!

cmahopper commented Aug 29, 2019

Uh oh!

yuryleb commented Aug 29, 2019

Uh oh!

cmahopper commented Aug 29, 2019

Uh oh!

1ec5 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone