misc refactoring

ProjectEvergreen · Feb 27, 2024 · 25480b3 · 25480b3
1 parent 2cda045
commit 25480b3
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 1 deletion.
diff --git a/packages/cli/src/lib/execute-route-module.js b/packages/cli/src/lib/execute-route-module.js
@@ -36,6 +36,7 @@ async function executeRouteModule({ moduleUrl, compilation, page = {}, prerender
     }
 
     // TODO cant we get these from just pulling from the file during the graph phase?
+    // https://github.com/ProjectEvergreen/greenwood/issues/991
     data.prerender = prerender;
     data.isolation = isolation;
   }

diff --git a/...ages/cli/src/lib/ssr-route-worker-prod.js → ...rc/lib/ssr-route-worker-isolation-mode.js b/...ages/cli/src/lib/ssr-route-worker-prod.js → ...rc/lib/ssr-route-worker-isolation-mode.js
diff --git a/packages/cli/src/lifecycles/graph.js b/packages/cli/src/lifecycles/graph.js
@@ -253,6 +253,8 @@ const generateGraph = async (compilation) => {
 
             const relativeApiPath = filenameUrl.pathname.replace(userWorkspace.pathname, '/');
             const route = `${basePath}${relativeApiPath.replace(`.${extension}`, '')}`;
+            // TODO should this be run in isolation like SSR pages?
+            // https://github.com/ProjectEvergreen/greenwood/issues/991
             const { isolation } = await import(filenameUrl).then(module => module);
 
             /*

diff --git a/packages/cli/src/lifecycles/serve.js b/packages/cli/src/lifecycles/serve.js
@@ -302,7 +302,7 @@ async function getHybridServer(compilation) {
           console.log('run SSR page in isolation mode!', { matchingRoute });
 
           await new Promise(async (resolve, reject) => {
-            const worker = new Worker(new URL('../lib/ssr-route-worker-prod.js', import.meta.url));
+            const worker = new Worker(new URL('../lib/ssr-route-worker-isolation-mode.js', import.meta.url));
             // TODO "faux" new Request here, a better way?
             const request = await requestAsObject(new Request(url));
 

diff --git a/packages/plugin-renderer-lit/src/execute-route-module.js b/packages/plugin-renderer-lit/src/execute-route-module.js
@@ -41,6 +41,7 @@ async function executeRouteModule({ moduleUrl, compilation, page, prerender, htm
     const { getTemplate = null, getBody = null, getFrontmatter = null, isolation } = module;
 
     // TODO cant we get these from just pulling from the file during the graph phase?
+    // https://github.com/ProjectEvergreen/greenwood/issues/991
     if (isolation) {
       data.isolation = true;
     }