Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor bundling lifecycle and resource optimizations #971

Closed
1 of 5 tasks
thescientist13 opened this issue Aug 7, 2022 · 0 comments · Fixed by #974 or #979
Closed
1 of 5 tasks

refactor bundling lifecycle and resource optimizations #971

thescientist13 opened this issue Aug 7, 2022 · 0 comments · Fixed by #974 or #979
Assignees
Labels
alpha.0 CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) v0.27.0
Milestone

Comments

@thescientist13
Copy link
Member

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Our rollup.config.js is doing a LOT of work that is potentially being duplicated not only in this file, but later on in our HTML optimization step, (where scripts and things are swapped out / updated). Since the beginning I had felt / wanted to refactor this because it felt wildly inefficient and redundant in a few places, but performed "well enough", but now I think this is a contributing factor to the benchmarking hangups potentially surfacing as part of #970 .

Details

I think we could simplify some of this a a lot. Things that seems like good opportunities to check for / refactor:


Even if it doesn't improve benchmarking that much, I think the refactoring opportunity alone is worth it and getting even a little more decoupled from any one bundler fits within the spirit of the project.

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) CLI labels Aug 7, 2022
@thescientist13 thescientist13 added this to the 1.0 milestone Aug 7, 2022
@thescientist13 thescientist13 self-assigned this Aug 7, 2022
@thescientist13 thescientist13 changed the title refactoring bundling and optimizations refactoring bundling lifecycle and optimizations Aug 14, 2022
@thescientist13 thescientist13 changed the title refactoring bundling lifecycle and optimizations refactor bundling lifecycle and resource optimizations Aug 14, 2022
@thescientist13 thescientist13 mentioned this issue Sep 22, 2022
27 tasks
@thescientist13 thescientist13 linked a pull request Sep 22, 2022 that will close this issue
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha.0 CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) v0.27.0
Projects
None yet
1 participant