Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable host check for devServer and fix host parsing #168

Merged
merged 6 commits into from
Aug 17, 2019
Merged

disable host check for devServer and fix host parsing #168

merged 6 commits into from
Aug 17, 2019

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Aug 16, 2019 •
edited
Loading

Related Issue

resolves #167

Summary of Changes

  1. Check for pathname instead
  2. Add disableHostCheck: true to devServer config

@thescientist13 thescientist13 added bug Something isn't working P0 Critical issue that should get addressed ASAP labels Aug 16, 2019
@thescientist13 thescientist13 changed the title disable host check or devServer disable host check for devServer and fix host parsing Aug 17, 2019
@thescientist13 thescientist13 merged commit 18161ae into master Aug 17, 2019
@thescientist13 thescientist13 deleted the bug/issue-167-dev-server-invalid-host-header branch August 17, 2019 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hutchgrant hutchgrant Awaiting requested review from hutchgrant

Assignees
No one assigned
Labels
bug Something isn't working P0 Critical issue that should get addressed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

devServer host configuration not working
1 participant
@thescientist13