Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close context menu in tutorial when label needs to be deleted #3027

Closed
jonfroehlich opened this issue Sep 15, 2022 · 4 comments · Fixed by #3296
Closed

Close context menu in tutorial when label needs to be deleted #3027

jonfroehlich opened this issue Sep 15, 2022 · 4 comments · Fixed by #3296
Assignees
Labels

Comments

@jonfroehlich
Copy link
Member

image

@jonfroehlich
Copy link
Member Author

I was also slightly confused by the instruction because when I first received it, there were two X's (one on the pop-up dialog and the other on the label itself):

image

@misaugstad
Copy link
Member

I always label curb ramps at the bottom-middle... but tutorial doesn't seem to like this

As of #3210 this is now fixed. For some reason the ideal location for most of the labels was set above the thing being labeled. I slightly adjusted them to be more in line with what we'd expect, so this now works.
Screenshot from 2023-04-19 13-12-10

I was also slightly confused by the instruction because when I first received it, there were two X's (one on the pop-up dialog and the other on the label itself):

I think that we should probably automatically close the context menu if the label is in the wrong place and we want the user to remove it. This deals with there being two X's, plus we just don't need to show this extra stuff on the screen when we want them to delete it anyway. Going to change the title for the issue to go after this.

@misaugstad misaugstad changed the title I always label curb ramps at the bottom-middle... but tutorial doesn't seem to like this Close context menu in tutorial when label needs to be deleted Apr 19, 2023
@misaugstad
Copy link
Member

Maybe we even prevent the context menu from opening at all in this case?

@jonfroehlich
Copy link
Member Author

This seems right to me:

I think that we should probably automatically close the context menu if the label is in the wrong place and we want the user to remove it. This deals with there being two X's, plus we just don't need to show this extra stuff on the screen when we want them to delete it anyway. Going to change the title for the issue to go after this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants