Initial PR for removing top Explain This button for feedback #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some notes:
|
|
@misaugstad The new commit reverted the random changes and also removed the entire bar, without changing anything from the mobile view! |
|
Great! Did we need to keep all of the text for the Validate page, or is there anything from there that we can remove? |
|
Is there specific text that you are looking at to remove? It looks good to me, and it seems there's no redundant code from the changes I've made and the functions I've deleted. |
…walk/SidewalkWebpage into 3250-remove-top-explain-this
…into 3250-remove-top-explain-this
…walk/SidewalkWebpage into 3250-remove-top-explain-this
…Webpage into 3250-remove-top-explain-this
misaugstad
requested changes
Jun 22, 2023
There was a problem hiding this comment.
Okay I didn't exhaustively go through everything, but I noted at least a few examples where translations/code still need to be removed, and one spot where some CSS was removed that shouldn't have been!
Can you go through everything again with a fine-toothed comb?
…walk/SidewalkWebpage into 3250-remove-top-explain-this
misaugstad
approved these changes
Jun 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3250
PR for removing the top bar "Explain This" issue.
Before:
After:
