-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed leaderboard text #3288
changed leaderboard text #3288
Conversation
…Webpage into 2989-leaderboard-text-change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one issue with the style guide to fix!
I also added anchor links to the sections on the user dashboard so that we could link directly to the section on recent mistakes :)
conf/messages.en-NZ
Outdated
dashboard.leave.org = Leave Organisation | ||
|
||
leaderboard.encouragement.no.org = <a id="encouragement-link" href="/dashboard"><u>Join an organisation</u></a> and work together as a team to map and assess footpaths! | ||
dashboard.leave.org = Leave Organisation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you accidentally removed the blank line at the end of this file, which should be included, as per the style guide! Can you just add the blank line back?
Oh and @lindseyehrlich make sure to pull in the recent changes I made to your branch before you make more updates! So after you check out this branch, you just need to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lindseyehrlich! First PR complete!
Yay!! |
Resolves #2989
Changed the "Join an organization" text on the leaderboard page, adding links to /labelingGuide and /dashboard
Before/After screenshots (if applicable)
Testing instructions
Things to check before submitting the PR