Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed leaderboard text #3288

Merged
merged 6 commits into from
Jul 11, 2023
Merged

changed leaderboard text #3288

merged 6 commits into from
Jul 11, 2023

Conversation

lindseyehrlich
Copy link
Collaborator

Resolves #2989

Changed the "Join an organization" text on the leaderboard page, adding links to /labelingGuide and /dashboard

Before/After screenshots (if applicable)
before after
Testing instructions
Things to check before submitting the PR
  • I've written a descriptive PR title.
  • I've included before/after screenshots above.
  • I've asked for and included translations for any user facing text that was added or modified.

Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one issue with the style guide to fix!

I also added anchor links to the sections on the user dashboard so that we could link directly to the section on recent mistakes :)

dashboard.leave.org = Leave Organisation

leaderboard.encouragement.no.org = <a id="encouragement-link" href="/dashboard"><u>Join an organisation</u></a> and work together as a team to map and assess footpaths!
dashboard.leave.org = Leave Organisation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you accidentally removed the blank line at the end of this file, which should be included, as per the style guide! Can you just add the blank line back?

@misaugstad
Copy link
Member

Oh and @lindseyehrlich make sure to pull in the recent changes I made to your branch before you make more updates! So after you check out this branch, you just need to run git pull or git pull origin 2989-leaderboard-text-change to get the recent changes that I made!

Copy link
Member

@misaugstad misaugstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lindseyehrlich! First PR complete!

@misaugstad misaugstad merged commit cf9b698 into develop Jul 11, 2023
@misaugstad misaugstad deleted the 2989-leaderboard-text-change branch July 11, 2023 00:33
@lindseyehrlich
Copy link
Collaborator Author

Yay!!

@misaugstad misaugstad mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On leaderboard, have "Want to improve your accuracy?"
2 participants