Standardizes indentation for JSON files #3291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha, I use 2 space indenting in VSCode 😂 But will defer to you since you're the lead! And I don't commit anything anyway. |
|
It seems like there is no real convention, unfortunately! I went with 4 space indents since that's what we're using in JavaScript, and they are basically just JavaScript objects 🤷 |
|
All good. I just find 4-space indentation quickly starts to balloon horizontally. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Half our our translations JSON files had 2 space indenting and half of them had 4 space indenting somehow. This led to weird issues with IDEs auto-formatting. I've just standardized it to 4-space indenting to make this more clear going forward.
Things to check before submitting the PR