2677 no validation missions mobile #3303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into 2677-no-validation-missions-mobile
|
@misaugstad For the third request, I'm not sure what that means. Do you want the page to show when there is only one or less validation mission? |
What I mean by this is that this screen should show up if you finish a validation mission and then you have none left after that. Just making sure that you don't only show it if there are no missions on the initial page load. It needs to be able to show up after any number of missions have been completed. Does that make sense? |
misaugstad
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
I made some updates to finish up the functionality. Thanks for the work you did on this @justyeethan!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2677
Summary
Completed changes for the no more validate page on mobile for all languages and verified that no more missions screen shows up when you exhaust validate mission.