Fixes bug preventing validating NoSidewalk labels #3403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3401
Fixes a bug that broke the "Validate more labels" button when the only labels left to validate are No Sidewalk labels.
The issue is that in the Mission Start Tutorial code, "NoSidewalk" was written as "NoSideWalk". Not sure how I missed that when testing the Mission Start Tutorial when it was first added, but this bug has been there from the beginning!
Since we only show No Sidewalk labels if all our main label types have already been fully validated by a user, this is only showing up on servers with very little data (like our new Walla Walla deployment).
Things to check before submitting the PR