Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Tutorial Screen to show the label count #3421

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

timkaltenbach
Copy link
Collaborator

@timkaltenbach timkaltenbach commented Nov 8, 2023

Resolves #3376

When creating the Tutorial Screen, we are passing in the label count as "nLabels" (example: Main.js, line 205)
It was currently trying to find the count at "labelCount", so I updated this

Before/After screenshots (if applicable)
Screenshot 2023-11-08 at 2 18 46 PM Screenshot 2023-11-08 at 2 18 57 PM
Things to check before submitting the PR
  • I've written a descriptive PR title.
  • I've added/updated comments for large or confusing blocks of code.
  • I've included before/after screenshots above.
  • I've asked for and included translations for any user facing text that was added or modified.
  • I've tested on mobile (only needed for validation page).

@timkaltenbach timkaltenbach changed the title 3376 missing label count Updated Tutorial Screen to show the mission count Nov 8, 2023
@misaugstad misaugstad changed the title Updated Tutorial Screen to show the mission count Updated Tutorial Screen to show the label count Nov 22, 2023
@misaugstad misaugstad merged commit c3a2b7d into develop Nov 22, 2023
@misaugstad misaugstad deleted the 3376-missing-label-count branch November 22, 2023 22:39
@misaugstad misaugstad mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate mission start title not showing number of labels to validate
2 participants