@findall
macro for multiple IDS objects
#42
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The previous
findall
method for multiple IDS objects is removed due to the ambiguous type inferences.Instead, a new
@findall
macro handles multiple IDS objects by calling thefindall
function for a single IDS object.The macro captures the input argument's names and passes them into a new keyword argument of the
root_name
of thefindall
function.This is beneficial for distinguishing different IDS objects more clearly as shown in below.
Existing feature
Existing
findall
cannot distinguish different IDS objects as it set the root_name by using thelocation
function.Suppose we have multiple different
dd
data, such asdd_D3D
anddd_FPP
.New feature
Note
New testset for "findall" is implemented.
[v] All tests passed