From 67526620599969e5e2781a155cbadb9c20c11740 Mon Sep 17 00:00:00 2001 From: Glutamat42 Date: Thu, 15 Feb 2024 16:05:47 +0100 Subject: [PATCH] pipeline update - phpunit workaround not required anymore as either moodle-plugin-ci bug was fixed or explicitly enabling pcov (instead of default phpdbg) for coverage avoids that bug (https://github.com/moodlehq/moodle-plugin-ci/issues/204) - update (unused) code checker to match new v4 of moodle-plugin-ci --- .github/workflows/moodle-ci.yml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/moodle-ci.yml b/.github/workflows/moodle-ci.yml index fbecfde..0a15644 100644 --- a/.github/workflows/moodle-ci.yml +++ b/.github/workflows/moodle-ci.yml @@ -101,7 +101,7 @@ jobs: # Coding style for this plugin differs from moodle's coding style in some points # - name: Moodle Code Checker # if: ${{ always() }} - # run: moodle-plugin-ci codechecker --max-warnings 0 + # run: moodle-plugin-ci phpcs --max-warnings 0 - name: Moodle PHPDoc Checker continue-on-error: true @@ -133,11 +133,7 @@ jobs: - name: PHPUnit tests if: ${{ always() }} run: | - cd moodle - php -d pcov.enabled=1 -d pcov.directory=. vendor/bin/phpunit --coverage-text --configuration availability/condition/adler --testdox --coverage-clover availability/condition/adler/coverage.xml - # restore tests are randomly causing segfaults when run with moodle-plugin-ci, but run totally fine when run with phpunit directly - # https://github.com/moodlehq/moodle-plugin-ci/issues/204 - # moodle-plugin-ci phpunit --fail-on-warning --coverage-clover --coverage-text -vvv + moodle-plugin-ci phpunit --fail-on-warning --coverage-clover --testdox --coverage-pcov --coverage-text -vvv - name: Coveralls upload continue-on-error: true