-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default initialization of PrometheusHandle #52
Conversation
Finally found the time to fix this issue. I tested the changes locally, and it no longer produces unbounded memory growth for me. Nonetheless, it'd be great to hear some feedback from someone else too before merging. Also, does it make sense to specify a default 5 seconds cc @gauravkumar37, @tobz, maybe @yanns |
I really appreciate this change, thanks! |
To my eyes, this looks right. 👍🏻 |
I'll go ahead and merge this as-is. I'll get back to handling the push gateway feature in a different PR. |
Addresses #51, based on metrics-rs/metrics#467.
This change prevents unbounded memory growth of metrics histograms by swapping
PrometheusHandle::install_recorder
toPrometheusHandle::build
, that allows the upkeep task to be created, and the data is properly drained.Other changes:
metrics
to0.23
,metrics-exporter-prometheus
to0.15
.TODO:
Figure out what to do whenpush-gateway
is enabled.