Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddingPowerSupport_CI/ #31

Merged
merged 2 commits into from
Dec 8, 2020
Merged

AddingPowerSupport_CI/ #31

merged 2 commits into from
Dec 8, 2020

Conversation

santosh653
Copy link
Contributor

Adding power support.,
Updating go versions to >=1.13 as lower versions are not supported.,

Adding power support.,
Updating go versions to >=1.13 as lower versions are not supported.,
@santosh653
Copy link
Contributor Author

Adding Power & Updating the go versions to 1.13/1.14/1.15 as lower versions are not supported.

Adding power support ppc64le with Continues Integration/testing so that code remains architecture independent.

This is part of the Ubuntu distribution for ppc64le. This helps us simplify testing later when distributions are re-building and re-releasing. For more info tag @gerrith3.

The build is successful on both arch: amd64/ppc64le, please find the Travis Link below.
https://travis-ci.com/github/santosh653/purell

Please let me know if you need any further details.,

Thank You !!

@mna
Copy link
Member

mna commented Dec 7, 2020

@gerrith3 same comment as PuerkitoBio/goquery#364 (comment)

@gerrith3
Copy link

gerrith3 commented Dec 8, 2020

@mna answered it over there, feel free to reach out if you have other questions. But @santosh653 should configure them any way you want them - we'd recommend sticking with a smaller set of modern go versions on ppc64le, but you can have him select more or all of the versions for amd64 as you desire.

@mna
Copy link
Member

mna commented Dec 8, 2020

Yeah let's not arbitrarily drop support for any old version on amd64, at least as long as travis or other CI let's us do so. Feel free to use just the versions you need on ppc. Would be nice to add the missing recent versions on amd64 though.

@gerrith3
Copy link

gerrith3 commented Dec 8, 2020

@mna makes sense. @santosh653 is in India, so he'll probably address this during our evening tonight. For both of these. ;)

Excluding go <=1.12.x as they are not supported on Power.,
@santosh653
Copy link
Contributor Author

@mna I have retained the old go versions on amd64 accordingly changed the code, also added the support for power using only the supported Go versions.

I hope this change answers & addresses your query., Looping @gerrith3
The Travis Build is successful with newly changed code.

Thank you !!

@mna mna merged commit 5a810c9 into PuerkitoBio:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants